Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: simplify config #874

Merged
merged 5 commits into from
Aug 31, 2019
Merged

Travis CI: simplify config #874

merged 5 commits into from
Aug 31, 2019

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Aug 28, 2019

Closes #867

Closes rust-random#741

This seems to require a couple of hacks unfortunately.
@BurntSushi
Copy link

Thanks! I think needing to add direct dependencies in order to make minimal versions work only happens because those dependencies themselves don't have minimal versions specified correctly? Or was there some other issue? I'd be happy to help submit PRs to those dependencies to make minimal versions work more smoothly.

@dhardy
Copy link
Member Author

dhardy commented Aug 28, 2019

I'm actually not sure. @vks is the author of average which depends on conv but it may be that the issue we hit with the min version is not actually a bug in average per se.

The other issue is with serde_derive which may be a "bug" @dtolnay: serde depends on serde_derive version 1.0, thus us depending on serde >= 1.0.63 does nothing.

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it would be also nice to add 32-bit tests, e.g. you can kill two birds by adding a WASM job.

.travis.yml Outdated
matrix:
include:
- rust: 1.32.0
env: DESCRIPTION="Linux, 1.32.0"
env: DESCRIPTION="Linux, 1.32.0" ALLOC=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now write it as:

name: "Linux, 1.32.0"
env: ALLOC=0

- cargo test --manifest-path rand_hc/Cargo.toml
- cargo test --manifest-path rand_jitter/Cargo.toml
- cargo test --manifest-path rand_os/Cargo.toml
- bash utils/ci/script.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need macOS and iOS tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know; possibly not. These aren't too slow in any case (unlike the WASM tests).

@vks
Copy link
Collaborator

vks commented Aug 29, 2019

Looks good to me! I'm not sure what the issue with the minimal conv version is, but most likely average should bump the minimal version (and test it) as @BurntSushi suggested. However, I think this can be done later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify CI config?
4 participants