-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI: simplify config #874
Conversation
Closes rust-random#741 This seems to require a couple of hacks unfortunately.
Thanks! I think needing to add direct dependencies in order to make minimal versions work only happens because those dependencies themselves don't have minimal versions specified correctly? Or was there some other issue? I'd be happy to help submit PRs to those dependencies to make minimal versions work more smoothly. |
I'm actually not sure. @vks is the author of The other issue is with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think it would be also nice to add 32-bit tests, e.g. you can kill two birds by adding a WASM job.
.travis.yml
Outdated
matrix: | ||
include: | ||
- rust: 1.32.0 | ||
env: DESCRIPTION="Linux, 1.32.0" | ||
env: DESCRIPTION="Linux, 1.32.0" ALLOC=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now write it as:
name: "Linux, 1.32.0"
env: ALLOC=0
- cargo test --manifest-path rand_hc/Cargo.toml | ||
- cargo test --manifest-path rand_jitter/Cargo.toml | ||
- cargo test --manifest-path rand_os/Cargo.toml | ||
- bash utils/ci/script.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need macOS and iOS tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know; possibly not. These aren't too slow in any case (unlike the WASM tests).
Looks good to me! I'm not sure what the issue with the minimal |
Closes #867