-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include! bindings.rs #226
include! bindings.rs #226
Conversation
7198323
to
166c630
Compare
8300a2a
to
9bab418
Compare
9bab418
to
6975d6f
Compare
6975d6f
to
915e66e
Compare
915e66e
to
68a9ef5
Compare
Here an update regarding the blockers for the PR: Rust Analyzerhas full support, but it must be enabled in the VSCode settings first: {
"rust-analyzer.cargoFeatures.loadOutDirsFromCheck": true,
} but Goto Definition is not yet working correctly: IntelliJ Rust
Otherwise it seems to work fine, so no blockers for IntelliJ Rust anymore. |
68a9ef5
to
921c6d4
Compare
The rust-analyzer team closed rust-lang/rust-analyzer#3767. |
Closed in favor of #798 |
Now that IntelliJ Rust has landed support for
include!(concat!(env!("OUT_DIR"), ..))
it's time to prepare a PR that generates thebindings.rs
file in the output directory and includes it fromskia-bindings/src/lib.rs
.To enable code insight in IntelliJ based IDEs, the experimental feature
org.rust.cargo.fetch.out.dir
has to be enabled. More information is available from the IntelliJ Rust team.I'll keep this PR open and unmerged until both IntelliJ Rust and Rust Analyzer are officially resolving
OUT_DIR
through the build script output as a faster alternative compared tocargo --build-plan
that is currently in use.Closes #10