Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include! bindings.rs #226

Closed
wants to merge 6 commits into from
Closed

Conversation

pragmatrix
Copy link
Member

Now that IntelliJ Rust has landed support for include!(concat!(env!("OUT_DIR"), ..)) it's time to prepare a PR that generates the bindings.rs file in the output directory and includes it from skia-bindings/src/lib.rs.

To enable code insight in IntelliJ based IDEs, the experimental feature org.rust.cargo.fetch.out.dir has to be enabled. More information is available from the IntelliJ Rust team.

I'll keep this PR open and unmerged until both IntelliJ Rust and Rust Analyzer are officially resolving OUT_DIR through the build script output as a faster alternative compared to cargo --build-plan that is currently in use.

Closes #10

@pragmatrix pragmatrix added enhancement New feature or request blocked labels Dec 4, 2019
@pragmatrix pragmatrix self-assigned this Dec 4, 2019
@pragmatrix pragmatrix force-pushed the include-bindings branch 2 times, most recently from 7198323 to 166c630 Compare December 22, 2019 09:55
@pragmatrix pragmatrix force-pushed the include-bindings branch 4 times, most recently from 8300a2a to 9bab418 Compare January 15, 2020 11:28
@pragmatrix
Copy link
Member Author

Here an update regarding the blockers for the PR:

Rust Analyzer

has full support, but it must be enabled in the VSCode settings first:

{
    "rust-analyzer.cargoFeatures.loadOutDirsFromCheck": true,
}

but Goto Definition is not yet working correctly:

rust-lang/rust-analyzer#3767

IntelliJ Rust

org.rust.cargo.fetch.out.dir must be set in "Experimental Features" (available through the Actions menu).

Otherwise it seems to work fine, so no blockers for IntelliJ Rust anymore.

@pragmatrix
Copy link
Member Author

The rust-analyzer team closed rust-lang/rust-analyzer#3767.

@pragmatrix
Copy link
Member Author

Closed in favor of #798

@pragmatrix pragmatrix closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont generate the bindings in src/bindings.rs
1 participant