Handwrite Error conformance so thiserror is not needed #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nivekuil, if you've got any input here I'd appreciate it! |
frewsxcv
approved these changes
Dec 30, 2019
andy128k
reviewed
Jan 2, 2020
andy128k
approved these changes
Jan 6, 2020
DCjanus
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 removed
failureand instead just conformedErrortostd::error::Error, which seems like a great change. Before seeing that change, I worked on a similar change forrssin rust-syndication/rss#82, although my approach turned out to be slightly different.thiserrorwas used to implement the trait here, and while it seems like an awesome crate, I'm not sure the convenience is worth it for the cost of adding additional dependencies. Every dependency to this crate means more crates that users have to download, more versions for them to deal with, and longer compile times.I handwrote an implementation of the trait, and while it's definitely more boilerplate, I don't think the ~30 extra lines are much of a maintenance burden, and it seems worth it to mean one less dependency in users' lockfiles.