Fix ]]>
escaping in CDATA
sections
#174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #173 by splitting
CDATA
sections by the]]>
search string and adding multipleBytesCData
events, if necessary.As mentioned in the linked issue, I've also reported this bug at
quick-xml
to clarify who's responsibility the escaping is. If the responsibility is on the caller then this PR should fix the issue.I ran
cargo bench
a couple of times onmaster
and this branch and it seems like the performance impact is negligible.Related:
]]>
inCDATA
is not escaped #173]]>
inCDATA
is not escaped tafia/quick-xml#831