Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation #359

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

simonsan
Copy link
Collaborator

@simonsan simonsan commented Apr 8, 2023

I'm a German native, so I can take care of taking this translation further than the initial step of running cloud-translate.

Output can be followed here: https://simonsan.github.io/patterns/de/

Status

  • run basic translation with cloud-translate
  • set up the initial state for rendering this language as a book
  • fix language picker dropdown not showing up
  • fix language picker position
  • manually fix translation errors and domain language up until 50% (so far 30% translated)
  • mention PoEdit in translations.md, so people are aware to not edit the po/xx.po files directly
  • LAST: remove translation-de branch from publish.yml in CI (only for working)

@simonsan simonsan added C-addition Category: Adding new content, something that didn't exist in the repository before A-translation Area: Everything regarding translations E-help wanted Call for participation: Help is requested to fix this issue labels Apr 8, 2023
@simonsan simonsan force-pushed the translation-de branch 2 times, most recently from 9660ac5 to 761cdff Compare April 9, 2023 02:25
Copy link
Contributor

@neithernut neithernut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just skimmed over the German translations for SUMMARY.md and found quite a few questionable translations. (comments in German)

po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
@simonsan
Copy link
Collaborator Author

simonsan commented Apr 9, 2023

I just skimmed over the German translations for SUMMARY.md and found quite a few questionable translations. (comments in German)

Hey there, this PR is not ready to review. ;-) The translations are at 30%. To see which translations are already made, you would need to use PoEdit. I think I will do until 40-50% of the translations and then merge it so others can chime in and PR against the translation.

@neithernut Feel free to PR against them then. Would be super helpful, actually. But take a small moment. ;)

PoEdit UI:
Untitled

@simonsan
Copy link
Collaborator Author

simonsan commented Apr 9, 2023

I might actually need to add that to the translations.md, so people are aware to not edit the xx.po file directly, but rather use PoEdit for it.

@simonsan simonsan added the C-stale Category: An issue/a PR that hasn't been worked on in a longer time (usually 90 days) label Dec 23, 2023
@simonsan
Copy link
Collaborator Author

I need to work myself into mdbook-i18n-helpers again, some stuff chained, and I think the ecosystem got more mature. Marking this as stale for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Everything regarding translations C-addition Category: Adding new content, something that didn't exist in the repository before C-stale Category: An issue/a PR that hasn't been worked on in a longer time (usually 90 days) E-help wanted Call for participation: Help is requested to fix this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants