Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an entry for 'module-companion for a function' idiom #417

Closed
wants to merge 4 commits into from

Conversation

JohnScience
Copy link

No description provided.

@simonsan
Copy link
Collaborator

simonsan commented Sep 8, 2024

Hey @JohnScience,
Thanks for opening this PR, after a short discussion we need to state, that this is something where the viability and complexity needs to be discussed first with the community, and we are not able to merge or review as is.

We feel like it adds too much complexity to a codebase, and we are unsure if the benefits are worth it. Of course, these things are highly subjective.

However, this was an interesting read, so we highly encourage you to write a blog post about it. If you don't have a personal blog, or you want our help let us know, and we will help you find the best way to share this article with the community, e.g. by sharing it on reddit and "this week in Rust".

The maintainers of this repo will also help you by re-sharing the blog post on their social media.
Once again, thank you for your effort and sorry if we aren't merging this.

I will copy the written article to our repository discussions, so people can talk about it and share their opinions.

@simonsan simonsan closed this Sep 8, 2024
@simonsan
Copy link
Collaborator

simonsan commented Sep 8, 2024

Discussion can be found here: #418

@MarcoIeni
Copy link
Collaborator

MarcoIeni commented Sep 8, 2024

Hi, I'm the other maintainer. Me and simonsan took the decision to close the PR together. I just wanted to thank you personally for the effort and repeat what simonsan told you: we strongly encourage to write this pattern as a blog post so that we can share it with the community.

Do you have a blog or a place where you can share this article?

@MarcoIeni
Copy link
Collaborator

Great, thanks!

You can also add it to this week in rust if you want: https://github.com/rust-lang/this-week-in-rust/tree/master/draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants