Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdline: port fix for issue reported in Firecracker #92

Closed
dianpopa opened this issue Sep 7, 2021 · 1 comment
Closed

cmdline: port fix for issue reported in Firecracker #92

dianpopa opened this issue Sep 7, 2021 · 1 comment

Comments

@dianpopa
Copy link

dianpopa commented Sep 7, 2021

An issue was opened against FIrecracker regarding the command line functionality.
We are working on a fix which should be brought over to rust-vmm's linux-loader crate too.
dianpopa added a commit to dianpopa/linux-loader that referenced this issue Sep 9, 2021
@dianpopa
cmdline: fix bug in cmdline handling
7f69904 
Fixes rust-vmm#92.
As per the documentation, everything that is
passed after "--" to the commandline is considered
an argument to init.
However, in the current implementation we are dynamically
adjusting the commandline by appending system specific information
(like mmio devices, root device).
As such, the region after "--" would contain more than init args.

Signed-off-by: Diana Popa <dpopa@amazon.com>
dianpopa added a commit to dianpopa/linux-loader that referenced this issue Sep 9, 2021
@dianpopa
cmdline: fix bug in cmdline handling
accd320 
Fixes rust-vmm#92.
As per the documentation, everything that is
passed after "--" to the commandline is considered
an argument to init.
However, in the current implementation we are dynamically
adjusting the commandline by appending system specific information
(like mmio devices, root device).
As such, the region after "--" would contain more than init args.

Signed-off-by: Diana Popa <dpopa@amazon.com>
dianpopa added a commit to dianpopa/linux-loader that referenced this issue Sep 10, 2021
@dianpopa
cmdline: fix bug in cmdline handling
23ec1d6 
Fixes rust-vmm#92.
As per the documentation, everything that is
passed after "--" to the commandline is considered
an argument to init.
However, in the current implementation we are dynamically
adjusting the commandline by appending system specific information
(like mmio devices, root device).
As such, the region after "--" would contain more than init args.

Signed-off-by: Diana Popa <dpopa@amazon.com>
@dianpopa dianpopa mentioned this issue Sep 10, 2021
Closed
dianpopa added a commit to dianpopa/linux-loader that referenced this issue Sep 23, 2021
@dianpopa
cmdline: fix bug in cmdline handling
3257e27 
Fixes rust-vmm#92.
As per the documentation, everything that is
passed after "--" to the commandline is considered
an argument to init.
However, in the current implementation we are dynamically
adjusting the commandline by appending system specific information
(like mmio devices, root device).
As such, the region after "--" would contain more than init args.

Signed-off-by: Diana Popa <dpopa@amazon.com>
andreeaflorescu added a commit to andreeaflorescu/firecracker that referenced this issue Sep 28, 2021
@andreeaflorescu
split the boot args in regular args and init args
92e994b 
This split is needede because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
dept implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Oct 7, 2021
@andreeaflorescu @dianpopa
split the boot args in regular args and init args
581293a 
This split is needede because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
dept implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Oct 8, 2021
@andreeaflorescu @dianpopa
split the boot args in regular args and init args
3251a88 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
depth implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Oct 8, 2021
@andreeaflorescu @dianpopa
split the boot args in regular args and init args
017cf1a 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
depth implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Oct 19, 2021
@andreeaflorescu @dianpopa
builder: place device related info at the start of cmdline
8d230c7 
This is needed because we're altering the kernel commandline
passed by Firecracker customers by appending device configuration (virtio
and root filesystem info). However, the cmdline can contain init params
which are expected to be at the end of the cmdline separated by "--".
Solved this by prepending all device related info.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
depth implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Oct 19, 2021
@andreeaflorescu @dianpopa
split the boot args in regular args and init args
6150361 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
debt implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
georgepisaltu pushed a commit to firecracker-microvm/firecracker that referenced this issue Oct 20, 2021
@andreeaflorescu @georgepisaltu
split the boot args in regular args and init args
5c6ceae 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
debt implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: #2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
alindima pushed a commit to alindima/firecracker that referenced this issue Nov 23, 2021
@andreeaflorescu @alindima
split the boot args in regular args and init args
4ca1f08 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
debt implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
alindima pushed a commit to firecracker-microvm/firecracker that referenced this issue Nov 24, 2021
@andreeaflorescu @alindima
split the boot args in regular args and init args
aefc93e 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
debt implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: #2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
gbionescu pushed a commit to gbionescu/firecracker that referenced this issue Feb 9, 2022
@andreeaflorescu @gbionescu
split the boot args in regular args and init args
2fff452 
This split is needed because we're altering the kernel commandline
passed by Firecracker customers to add virtio device configuration (on
x86_64). The virtio config needs to be specified *before* the init.

This is not the ideal implementation of the fix, as it would make more
sense to have it in rust-vmm/linux-loader. Due to existing technical
debt implementing it directly in upstream is not straightforward.
See: rust-vmm/linux-loader#92.

Fixes: firecracker-microvm#2709

Signed-off-by: Andreea Florescu <fandree@amazon.com>
@alxiord
Copy link
Member

alxiord commented Nov 15, 2022

#115

@alxiord alxiord closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmdline: fix bug in cmdline handling dianpopa/linux-loader
2 participants
@alxiord @dianpopa