-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add riscv64 support #72
base: main
Are you sure you want to change the base?
Conversation
bd33748
to
33a7db3
Compare
thanks for the contribution. while it overall looks good, we don't have any riscv support in the CI. Without that, I don't think we can merge such PRs, since it would basically result in untested code being released. |
Thank!
It looks like there's a PR adding that: rust-vmm/rust-vmm-ci#148
I think another possible way could be merging riscv64 support and labeling riscv64 as a community supported and not officially tested architecture in the documentation. BTW here is a test log on riscv64: https://paste.rs/Oyi0p |
- Add to qemu-user blacklist because qemu doesn't implement ptrace so test will fail in qemu-user - Disable seccomp-bpf feature because upstream seccompiler doesn't support riscv64 and it appears that they don't plan to merge my PR before riscv CI is setup: rust-vmm/seccompiler#72 - I am the author of this software BTW :)
- Add to qemu-user blacklist because qemu doesn't implement ptrace so test will fail in qemu-user - Disable seccomp-bpf feature because upstream seccompiler doesn't support riscv64 and it appears that they don't plan to merge my PR before riscv CI is setup: rust-vmm/seccompiler#72 - I am the author of this software BTW :)
Signed-off-by: kxxt <rsworktech@outlook.com>
- Fix rotten - Use my fork of seccompiler for enabling seccomp-bpf feature, previous upstream PR: rust-vmm/seccompiler#72
- Fix rotten - Use my fork of seccompiler for enabling seccomp-bpf feature, previous upstream PR: rust-vmm/seccompiler#72
Summary of the PR
Add riscv64 support.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.