Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot. #32

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Enable dependabot. #32

merged 3 commits into from
Dec 5, 2023

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Nov 27, 2023

This should help us keep on top of dependency version updates.

@jalil-salame
Copy link
Contributor

In this case merging is blocked by a clippy lint which looks like a manual impl of an async mutex... LGTM but that needs to be investigated.

@jalil-salame
Copy link
Contributor

jalil-salame commented Nov 28, 2023

Seemed straight forward enough to fix: #33

If it gets merged you can rebase this branch on top of it to make the CI happy c:

@qwandor qwandor requested a review from a team November 29, 2023 10:53
This should help us keep on top of dependency version updates.

Signed-off-by: Andrew Walbran <qwandor@google.com>
They may be long due to URLs and commit hashes.

Signed-off-by: Andrew Walbran <qwandor@google.com>
No need to use a hash directly.

Signed-off-by: Andrew Walbran <qwandor@google.com>
@jalil-salame
Copy link
Contributor

Rebased on top of master, now the workflows should pass

Copy link
Contributor

@jalil-salame jalil-salame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/commit-message-check.yaml Show resolved Hide resolved
@Tim-Zhang Tim-Zhang merged commit 8bbb4f8 into master Dec 5, 2023
2 checks passed
@Tim-Zhang Tim-Zhang deleted the dependabot branch December 5, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants