Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect errors on calls to *MakeCurrent #84

Closed
tomaka opened this issue Oct 27, 2014 · 3 comments
Closed

Detect errors on calls to *MakeCurrent #84

tomaka opened this issue Oct 27, 2014 · 3 comments
Labels
CGL help wanted

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 27, 2014

For the moment, calls to wglMakeCurrent, glXMakeCurrent, etc. can silently fail.
The return type of make_current should be a Result<(), MakeCurrentError>.
emilio pushed a commit to emilio/glutin that referenced this issue May 12, 2016
Auto merge of rust-windowing#84 - servo:merge-upstream, r=jdm
b6a9f8c 
Merge from upstream.

We need rust-windowing#769 for servo/servo#10836.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/84)
<!-- Reviewable:end -->
tomaka added a commit that referenced this issue Aug 29, 2017
@tomaka
Merge pull request #84 from vberger/master
2c90eeb 
linux: remove outdated comment
@goddessfreya
Copy link
Contributor

Has already been fixed.

@goddessfreya goddessfreya reopened this Feb 26, 2019
@goddessfreya
Copy link
Contributor

Nvm, damn macos & emscripten

@goddessfreya goddessfreya mentioned this issue May 9, 2019
Closed
@kchibisov
Copy link
Member

I'll close this, given that there's no evidence of error handling on macOS for context stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CGL help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomaka @goddessfreya @kchibisov