Glutin0.23 android #1274

dvc94ch · 2020-02-05T19:54:32Z

Tested on all platforms changed
Compilation warnings were addressed
cargo fmt has been run on this branch
cargo doc builds successfully
Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality

goddessfreya

I've taken a quick look at the PR, but I haven't tested it yet.

src/context.rs

src/platform_impl/android/android.rs

examples/window.rs

src/api/egl.rs

goddessfreya · 2020-02-07T05:59:02Z

To handle the android lifetime cycle thing, can't we just have users drop the Surface and recreate it with new_existing when their application resumes? Is that not like the whole point of new_existing? Why does glutin have to drop it internally when the users can drop it themselves? I think this would be a better solution than platform-specific functions or weird callback setting functions on glutin_interface.

examples/window.rs

dvc94ch · 2020-02-07T18:31:38Z

actually if all platforms emit Suspend Resume in winit and the glutin api gains a Surface::<Window>::build_window() -> Window, not sure about other platform's requirements, I think it would be neat.

goddessfreya · 2020-02-08T08:19:10Z

Are you suggesting something like this? I'm not very pleased with this solution, but maybe I missunderstood. glutin::platform_impl::Config and winit::platform_impl::EventLoop must be Clone.

Ah, well, glutin::platform_impl::Config should be clone. I marked the ones in src/api/{glx,egl}.rs as such, but forgot to mark the types in src/platform_impl/unix/*, so oops. I've updated the sendsync test to also check for clone.

Meanwhile, you don't need an winit::platform_impl::EventLoop, but instead an &winit::platform_impl::EventLoopWindowTarget, which is the second param that winit passes to the run closure, so no need to clone the eventloop.

I should also note that dropping Surf automatically makes it not current, so you don't need the make_not_current in Suspended.

I guess if there was a Surface::<Window>::build_window() -> Window and Surface::<Window>::new() was implemented as (Self::build_window(), Self::new_existing()) it would be less weird.

This sounds like an excellent idea, now that I come to think of it. Yeah, we should do that and then platforms don't have to implement new and instead only new_existing.

actually if all platforms emit Suspend Resume in winit and the glutin api gains a Surface::::build_window() -> Window, not sure about other platform's requirements, I think it would be neat.

Yeah, should be fine on GLX and EGL, as, like I mentioned above, that is what was intended. Off my limited knowledge of how WGL works, I can't imagine anything will go wrong. No clue about cocoa though.

goddessfreya · 2020-02-08T17:55:28Z

examples/window.rs

+                    WindowEvent::Resized(size) => size,
+                    WindowEvent::CloseRequested => {
+                        *control_flow = ControlFlow::Exit;
+                        return;


Are these returns necessary?

examples/window.rs

src/api/egl.rs

src/surface.rs

src/api/egl.rs

goddessfreya

Minor doc nitpick. Otherwise, this PR is only waiting on the appropriate winit changes :D

src/surface.rs

dvc94ch · 2020-02-09T09:04:58Z

I rebased the changes and I think you can merge all except the last commit which is specific to the winit changes. That way I don't hold up other platform implementations.

goddessfreya · 2020-02-09T19:07:32Z

Okay, one last thing (I swear): is this comment still up to date?

https://github.com/rust-windowing/glutin/pull/1274/files#diff-5ce72bac836d0ca6fa8f3082f38d28d2L170-L172

dvc94ch · 2020-02-09T19:20:06Z

I can't find the comment, I think the commit you linked is outdated? Github does some weird caching sometimes.

goddessfreya · 2020-02-09T20:54:13Z

https://github.com/dvc94ch/glutin/blob/glutin0.23-android/src/api/egl.rs#L178-L180

README.md

dvc94ch · 2020-02-17T18:09:13Z

.github/workflows/ci.yml

        path: winit
-        ref: winit-glutin-next
+        ref: winit-glutin-next-android


NOTE to self

dvc94ch · 2020-02-17T18:09:29Z

.github/workflows/ci.yml

+      if: contains(matrix.platform.target, 'android')
+      # FIXME
+      run: cargo install --git https://github.com/dvc94ch/android-ndk-rs --branch android-glue
+


NOTE to self

goddessfreya

Can glutin's readme be amended with instructions for building the examples on android?

examples/window.rs

dvc94ch · 2020-11-27T12:51:08Z

Closing due to inactivity

dvc94ch force-pushed the glutin0.23-android branch from 691cfc9 to e6b7185 Compare February 5, 2020 19:55

dvc94ch mentioned this pull request Feb 5, 2020

Update android backend. #1249

Closed

goddessfreya suggested changes Feb 6, 2020

View reviewed changes

goddessfreya reviewed Feb 7, 2020

View reviewed changes

src/api/egl.rs Outdated Show resolved Hide resolved

goddessfreya reviewed Feb 7, 2020

View reviewed changes

src/api/egl.rs Outdated Show resolved Hide resolved

goddessfreya reviewed Feb 7, 2020

View reviewed changes

examples/window.rs Outdated Show resolved Hide resolved

examples/window.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dvc94ch force-pushed the glutin0.23-android branch 3 times, most recently from 67ffe71 to b8904e1 Compare February 8, 2020 12:05

dvc94ch requested a review from goddessfreya February 8, 2020 12:06

goddessfreya suggested changes Feb 8, 2020

View reviewed changes

goddessfreya approved these changes Feb 8, 2020

View reviewed changes

src/surface.rs Outdated Show resolved Hide resolved

dvc94ch force-pushed the glutin0.23-android branch from 21542a3 to 176b218 Compare February 9, 2020 09:02

dvc94ch force-pushed the glutin0.23-android branch from 176b218 to 2904943 Compare February 10, 2020 07:26

dvc94ch mentioned this pull request Feb 10, 2020

android part1 #1278

Merged

dvc94ch force-pushed the glutin0.23-android branch 3 times, most recently from 0379295 to e68b47a Compare February 12, 2020 09:45

goddessfreya added this to the Next Release (v0.24) milestone Feb 16, 2020

goddessfreya reviewed Feb 17, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

dvc94ch force-pushed the glutin0.23-android branch 2 times, most recently from 3308ab6 to e95efe7 Compare February 17, 2020 17:45

dvc94ch force-pushed the glutin0.23-android branch 3 times, most recently from 85773f9 to 4c12045 Compare February 17, 2020 18:07

dvc94ch commented Feb 17, 2020

View reviewed changes

Implement android backend.

a792317

dvc94ch force-pushed the glutin0.23-android branch from 63f06fd to a792317 Compare February 17, 2020 19:47

goddessfreya suggested changes Feb 17, 2020

View reviewed changes

goddessfreya reviewed Feb 17, 2020

View reviewed changes

examples/window.rs Show resolved Hide resolved

goddessfreya mentioned this pull request Feb 17, 2020

Implementation tracking and API discussions for v0.24 #1271

Closed

18 tasks

Update window example.

ad4ae79

dvc94ch force-pushed the glutin0.23-android branch from 0b2e694 to ad4ae79 Compare February 19, 2020 08:37

kchibisov mentioned this pull request Jun 11, 2020

Error compiling to Android with cargo apk #1307

Closed

dvc94ch closed this Nov 27, 2020

dvc94ch mentioned this pull request Feb 10, 2021

ndk-glue does not handle NativeWindow lifecycle correctly rust-mobile/ndk#117

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glutin0.23 android #1274

Glutin0.23 android #1274

dvc94ch commented Feb 5, 2020

goddessfreya left a comment

goddessfreya commented Feb 7, 2020

This comment has been minimized.

dvc94ch commented Feb 7, 2020

goddessfreya commented Feb 8, 2020

goddessfreya Feb 8, 2020

goddessfreya left a comment

dvc94ch commented Feb 9, 2020

goddessfreya commented Feb 9, 2020

dvc94ch commented Feb 9, 2020 •

edited

Loading

goddessfreya commented Feb 9, 2020

dvc94ch Feb 17, 2020

dvc94ch Feb 17, 2020

goddessfreya left a comment

dvc94ch commented Nov 27, 2020

Glutin0.23 android #1274

Glutin0.23 android #1274

Conversation

dvc94ch commented Feb 5, 2020

goddessfreya left a comment

Choose a reason for hiding this comment

goddessfreya commented Feb 7, 2020

This comment has been minimized.

dvc94ch commented Feb 7, 2020

goddessfreya commented Feb 8, 2020

goddessfreya Feb 8, 2020

Choose a reason for hiding this comment

goddessfreya left a comment

Choose a reason for hiding this comment

dvc94ch commented Feb 9, 2020

goddessfreya commented Feb 9, 2020

dvc94ch commented Feb 9, 2020 • edited Loading

goddessfreya commented Feb 9, 2020

dvc94ch Feb 17, 2020

Choose a reason for hiding this comment

dvc94ch Feb 17, 2020

Choose a reason for hiding this comment

goddessfreya left a comment

Choose a reason for hiding this comment

dvc94ch commented Nov 27, 2020

dvc94ch commented Feb 9, 2020 •

edited

Loading