[macos] find latest GL version #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
mac-hw-accel
branch
3 times, most recently
from
64a0712 to
1b0ca01
Compare
|
The only non-mac specific change is with the headless context parameters, and it's also the one I'm least confident about. Previously, mac platform didn't ever pass the accelerated pixel format requirement, which resulted, so headless contexts worked. Now that I made it respect the acceleration flag, I had to avoid the default pixel requirements for the headless mode. This is confusing, since I don't see headless context having clear semantics (hello, pure contexts of #942). Anyhow, this PR is ready for review now, @tomaka . It is somewhat important since currently any Mac not supporting GL 4.1 switches to software rendering. |
This was referenced Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781
When
Latestnon-compatibility version is requested, try 4.1 and 3.2 explicitly instead of relying on software versions.Also pass in the HW accelerated and double-buffer flags according to the given options.
Note: according to the docs, not passing the double-buffer flag equals to requesting single buffering.