Implement HasRaw*Handle for all Has*Handle

Signed-off-by: John Nunley <dev@notgull.net>
rust-windowing · Sep 2, 2023 · 87f2174 · 87f2174
1 parent 297078d
commit 87f2174
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 65 deletions.
diff --git a/src/borrowed.rs b/src/borrowed.rs
@@ -82,13 +82,6 @@ pub struct DisplayHandle<'a> {
     _marker: PhantomData<&'a *const ()>,
 }
 
-#[allow(deprecated)]
-unsafe impl crate::HasRawDisplayHandle for DisplayHandle<'_> {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        Ok(self.raw)
-    }
-}
-
 impl fmt::Debug for DisplayHandle<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_tuple("DisplayHandle").field(&self.raw).finish()
@@ -264,13 +257,6 @@ impl<'a> WindowHandle<'a> {
     }
 }
 
-#[allow(deprecated)]
-unsafe impl crate::HasRawWindowHandle for WindowHandle<'_> {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        Ok(self.raw.clone())
-    }
-}
-
 impl AsRef<RawWindowHandle> for WindowHandle<'_> {
     fn as_ref(&self) -> &RawWindowHandle {
         &self.raw

diff --git a/src/lib.rs b/src/lib.rs
@@ -77,31 +77,9 @@ pub unsafe trait HasRawWindowHandle {
 }
 
 #[allow(deprecated)]
-unsafe impl<'a, T: HasRawWindowHandle + ?Sized> HasRawWindowHandle for &'a T {
+unsafe impl<T: HasWindowHandle + ?Sized> HasRawWindowHandle for T {
     fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        (*self).raw_window_handle()
-    }
-}
-#[allow(deprecated)]
-unsafe impl<'a, T: HasRawWindowHandle + ?Sized> HasRawWindowHandle for &'a mut T {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        (**self).raw_window_handle()
-    }
-}
-#[cfg(feature = "alloc")]
-#[cfg_attr(docsrs, doc(cfg(feature = "alloc")))]
-#[allow(deprecated)]
-unsafe impl<T: HasRawWindowHandle + ?Sized> HasRawWindowHandle for alloc::rc::Rc<T> {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        (**self).raw_window_handle()
-    }
-}
-#[cfg(feature = "alloc")]
-#[cfg_attr(docsrs, doc(cfg(feature = "alloc")))]
-#[allow(deprecated)]
-unsafe impl<T: HasRawWindowHandle + ?Sized> HasRawWindowHandle for alloc::sync::Arc<T> {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        (**self).raw_window_handle()
+        self.window_handle().map(Into::into)
     }
 }
 
@@ -227,34 +205,9 @@ pub unsafe trait HasRawDisplayHandle {
 }
 
 #[allow(deprecated)]
-unsafe impl<'a, T: HasRawDisplayHandle + ?Sized> HasRawDisplayHandle for &'a T {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        (*self).raw_display_handle()
-    }
-}
-
-#[allow(deprecated)]
-unsafe impl<'a, T: HasRawDisplayHandle + ?Sized> HasRawDisplayHandle for &'a mut T {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        (**self).raw_display_handle()
-    }
-}
-
-#[cfg(feature = "alloc")]
-#[cfg_attr(docsrs, doc(cfg(feature = "alloc")))]
-#[allow(deprecated)]
-unsafe impl<T: HasRawDisplayHandle + ?Sized> HasRawDisplayHandle for alloc::rc::Rc<T> {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        (**self).raw_display_handle()
-    }
-}
-
-#[cfg(feature = "alloc")]
-#[cfg_attr(docsrs, doc(cfg(feature = "alloc")))]
-#[allow(deprecated)]
-unsafe impl<T: HasRawDisplayHandle + ?Sized> HasRawDisplayHandle for alloc::sync::Arc<T> {
+unsafe impl<T: HasDisplayHandle + ?Sized> HasRawDisplayHandle for T {
     fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        (**self).raw_display_handle()
+        self.display_handle().map(Into::into)
     }
 }