Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from objc to objc2 #181

Closed
notgull opened this issue Nov 15, 2023 · 1 comment · Fixed by #210
Closed

Migrate from objc to objc2 #181

notgull opened this issue Nov 15, 2023 · 1 comment · Fixed by #210
Assignees
@madsmtm

Comments

@notgull
Copy link
Member

notgull commented Nov 15, 2023

No description provided.

@notgull notgull mentioned this issue Nov 24, 2023
Open
65 tasks
@ids1024
Copy link
Member

ids1024 commented Dec 4, 2023

Presumably this depends on servo/core-foundation-rs#628. Then would be fairly simple. (I'm not familiar with exactly how either crate works though).

@madsmtm madsmtm mentioned this issue Apr 23, 2024
Merged
notgull pushed a commit that referenced this issue Apr 29, 2024
@madsmtm
deps: Use objc2
28ebe6e 
Fixes #181.

This also prevents accessing the `NSView`/`NSWindow` from other threads than the main thread.

SoftBufferError is `#[non_exhaustive]`, so it's fine to add further
variants to it. I decided against doing that though, as the error is
platform-specific, and not one that the program can really handle in any
reasonable way (it's closer to a programmer error).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madsmtm madsmtm

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use objc2 rust-windowing/softbuffer
3 participants
@ids1024 @madsmtm @notgull