Skip to content

Commit

Permalink
Fix Window visibility regression (#1994)
Browse files Browse the repository at this point in the history
On Windows, set windows visible on init before position update

Ensure that the style change is correctly applied, triggering the necessary events.
  • Loading branch information
msiglreith authored Aug 12, 2021
1 parent 1972eb9 commit b87757c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/platform_impl/windows/window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,10 @@ unsafe fn post_init<T: 'static>(
thread_executor: event_loop.create_thread_executor(),
};

// Set visible before setting the size to ensure the
// attribute is correctly applied.
win.set_visible(attributes.visible);

let dimensions = attributes
.inner_size
.unwrap_or_else(|| PhysicalSize::new(800, 600).into());
Expand All @@ -891,7 +895,6 @@ unsafe fn post_init<T: 'static>(
// `Window::set_inner_size` changes MAXIMIZED to false.
win.set_maximized(true);
}
win.set_visible(attributes.visible);

if let Some(_) = attributes.fullscreen {
win.set_fullscreen(attributes.fullscreen);
Expand Down

0 comments on commit b87757c

Please sign in to comment.