Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't figure out the event loop and nothing should be further from the case. #1054

Closed
cheako opened this issue Jul 21, 2019 · 13 comments
Closed
Labels
F - question There's no such thing as a stupid one S - api Design and usability

Comments

@cheako
Copy link

cheako commented Jul 21, 2019

There should be no mistake in the description of the event loop that's implemented multiple times and will likely be tested on one time but run across many.

Looks like entire sections are incomplete.

Edit: #459 (comment)

@goddessfreya goddessfreya added S - api Design and usability F - question There's no such thing as a stupid one labels Jul 21, 2019
@cheako
Copy link
Author

cheako commented Jul 22, 2019

Sorry, I posted that reply to the wrong issue. The documentation is still incomplete.

@goddessfreya goddessfreya reopened this Jul 22, 2019
@Osspial
Copy link
Contributor

Osspial commented Jul 23, 2019

Got any specific feedback points? It's hard to address your issues when you only give a vague problem, and the solution you describe in your #459 comments doesn't solve the problem you seem to be having in this issue.

Also, does the improved documentation in #1032 address any of the clarity issues you've brought up?

@cheako
Copy link
Author

cheako commented Jul 23, 2019

#1032 is a good start, it is however impossible to know now if I know enough of what I don't know.

@cheako
Copy link
Author

cheako commented Jul 24, 2019

I thought to look at some of the examples, though if that's a requirement then the relevant examples need to be linked.

This example is of how to use match and not much more.
https://github.com/rust-windowing/winit/blob/master/examples/request_redraw.rs

Edit as is at least one more.

@Osspial
Copy link
Contributor

Osspial commented Jul 25, 2019

@cheako If you find the examples or documentation unsatisfactory, please go ahead and open a PR that improves them! I'll fully admit that that particular example isn't great, but from the sound of things you've got ideas for how to improve it, and the best way to show off those ideas is to just go ahead and implement them.

@cheako
Copy link
Author

cheako commented Jul 26, 2019

I don't know what I don't know.

@cheako
Copy link
Author

cheako commented Jul 27, 2019

For X11_alpha2 the first event is EventsCleared, not StartCause::Init?

https://gitlab.com/cheako/hazel/blob/afce20a2bd0a1093ed3630f6916445e003e6ee5e/examples/sandbox.rs#L117
Jul 27 01:05:18.318 TRCE Init Event: EventsCleared

@goddessfreya
Copy link
Contributor

We do not expose any event known as StartCause::Init

@cheako
Copy link
Author

cheako commented Jul 30, 2019

@goddessfreya
Copy link
Contributor

@murarth Can you reproduce an EventsCleared event being generated before the NewEvents?

@murarth
Copy link
Contributor

murarth commented Jul 30, 2019

@zegentzy: Unable to reproduce and I don't see how that could possibly happen. The first thing EventLoop::run_return does, before entering the main loop, is unconditionally call the callback with NewEvents(StartCause::Init): https://github.com/rust-windowing/winit/blob/master/src/platform_impl/linux/x11/mod.rs#L251-L255

@Osspial
Copy link
Contributor

Osspial commented Jul 30, 2019

@cheako

I don't know what I don't know.

I'll point out that you've brought up multiple specific documentation problems that have been an impedance to your understanding of our API. Given that context, this comment makes it seem like you're more interested in complaining about our problems than you are with actually fixing them. That may or may not be the case (I'm hoping it's not!), but it's the image you're presenting and it's impossible for me to ignore.


The GitLab link you've provided is broken, and I'm unable to reproduce your issue on master. Could you open a new issue with a relatively compact test case that reproduced it? I'll say that, skimming through the X11 source, the issue you describe should be impossible. @murarth posted a good explanation why.

As a side note, since I don't know if you're doing this on purpose - it seems like a lot of the comments you've been making have consistently been off-topic, unclear, or dismissive. That, combined with your stream-of-consciousness style of writing, has made it frustrating to understand your complaints and work with you to solve the issues you've been describing. Please work on addressing those issues. I'd suggest that, after you write your comments, you wait a bit and read over them before posting them, so you can make sure you're coherently and respectfully communicating your intent.

@goddessfreya
Copy link
Contributor

@zegentzy: Unable to reproduce and I don't see how that could possibly happen. The first thing EventLoop::run_return does, before entering the main loop, is unconditionally call the callback with NewEvents(StartCause::Init): https://github.com/rust-windowing/winit/blob/master/src/platform_impl/linux/x11/mod.rs#L251-L255

Yeah, that's what I was thinking too, @murarth... maybe it's the weirdest heisenbug ever (not to give nightmares or anything :D)?

Anyways- given that this issue has strayed far off from it's original, albeit vague, purpose, I'm closing it. In the future, please provide specific feedback points, instead of musings on ill-defined "problems".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F - question There's no such thing as a stupid one S - api Design and usability
Development

No branches or pull requests

4 participants