Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resize increments #135

Closed
siiptuo opened this issue Feb 11, 2017 · 13 comments
Closed

Support resize increments #135

siiptuo opened this issue Feb 11, 2017 · 13 comments
Assignees
@francesca64
Labels
C - in progress Implementation is proceeding smoothly D - easy Likely easier than most tasks here DS - macos P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@siiptuo
Copy link
Contributor

siiptuo commented Feb 11, 2017

Basically this means restricting window size to multiples of some defined size. X11 and OS X provide this feature. Windows doesn't seem to have support for this but it could be emulated with additional code. Not sure about Wayland.

This feature is probably only useful for terminal emulators like Alacritty. So is it worth to be added to the library?
@tomaka
Copy link
Contributor

tomaka commented Feb 11, 2017

It should be possible already to set both the min and max dimensions to the same size.

@tomaka tomaka added S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Feb 11, 2017
@siiptuo
Copy link
Contributor Author

siiptuo commented Feb 11, 2017

At least for me, setting min and max dimensions to the same size simply creates an unresizable window. The desired behaviour would be the following: when increment size is for instance 20x10, allowed window sizes are 20x10, 40x10, 20x20, 40x20 etc.

@francesca64
Copy link
Member

I'd be more inclined to add this to WinodwBuilderExt than to try to emulate the feature on Windows, since that sounds like it could get messy easily.

Do you know if X11's resize increments actually work? It might sound like a silly question, but it wouldn't surprise me if WM support is poor.

@siiptuo
Copy link
Contributor Author

siiptuo commented Apr 24, 2018

I'm unable to find any list, but based on my experience, resize increments are set by many X11 terminal emulators and supported by many (stacking) window managers.

@francesca64
Copy link
Member

Alright, thanks. This looks really easy to implement, so I can knock this out for both platforms after I finish the X11 refactor I'm working on.

@siiptuo
Copy link
Contributor Author

siiptuo commented Apr 26, 2018

Sound great!

One related property that could also be supported is base size. It works something like this: window_width = base_width + x * width_inc. This is useful if the window has a toolbar or padding. Unfortunately only X11 seems to support it.

@francesca64
Copy link
Member

X11 implementation on this branch: https://github.com/francesca64/winit/tree/x11-resize-inc

I added with_resize_increments(width_inc: i32, height_inc: i32) and with_base_size(base_width: i32, base_height: i32) to WindowBuilderExt. If you don't specify base size, it defaults to the window dimensions.

@siiptuo
Copy link
Contributor Author

siiptuo commented May 1, 2018

Thanks! This works as it should.

However base size should not default to the window dimensions because this basically sets the minimum size. Instead base size should not be set at all by default.

@francesca64 francesca64 mentioned this issue May 2, 2018
Merged
@francesca64
Copy link
Member

Gotcha, I've corrected that. #494

You can expect this to be in the next release, though I still need to implement this on macOS.

@francesca64 francesca64 added DS - macos DS - x11 C - in progress Implementation is proceeding smoothly D - easy Likely easier than most tasks here P - low Nice to have labels May 6, 2018
@francesca64 francesca64 self-assigned this May 6, 2018
francesca64 added a commit to francesca64/winit that referenced this issue May 15, 2018
@francesca64
macOS: Implement with_resize_increments
02f49cb 
Fixes rust-windowing#135
francesca64 added a commit to francesca64/winit that referenced this issue May 15, 2018
@francesca64
macOS: Implement with_resize_increments
8b45fcc 
Fixes rust-windowing#135
francesca64 added a commit to francesca64/winit that referenced this issue May 15, 2018
@francesca64
macOS: Implement with_resize_increments
16c949c 
Fixes rust-windowing#135
@francesca64 francesca64 mentioned this issue May 15, 2018
Merged
@francesca64
Copy link
Member

macOS implementation: #519

(Sorry this took so long, considering how simple it was!)

francesca64 added a commit to francesca64/winit that referenced this issue May 15, 2018
@francesca64
macOS: Implement with_resize_increments
46e9b63 
Fixes rust-windowing#135
francesca64 added a commit that referenced this issue May 16, 2018
@francesca64
macOS: Implement with_resize_increments (#519)
8440091 
Fixes #135
@necauqua necauqua mentioned this issue Sep 4, 2021
Closed
madsmtm added a commit to madsmtm/winit that referenced this issue Jun 11, 2022
@amrbashir @wravery
@renovate @renovate-bot @lucasfernog @probablykasper @parasyte @madsmtm @MultisampledNight @aurelj
Merge next back to dev branch (rust-windowing#305)
0dd7197 
* refactor(windows): `begin_resize_drag` now similar to gtk's (rust-windowing#200)

* refactor(windows): `begin_resize_drag` now similart to gtk's

* fix

* feat(linux): skipping taskbar will now also skip pager (rust-windowing#198)

* refactor(linux): clean dummy device_id (rust-windowing#195)

* refactor(linux): clean dummy device_id

* fmt

* feat(linux): allow resizing undecorated window using touch (rust-windowing#199)

* refactor(windows): only skip taskbar if needed when `set_visible` is called (rust-windowing#196)

* fix: increase borderless resizing inset (rust-windowing#202)

* fix: increase borderless resizing inset

* update some comments

* Replace winapi with windows crate bindings shared with WRY (rust-windowing#206)

* fix(deps): update rust crate libayatana-appindicator to 0.1.6 (rust-windowing#190)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Add Windows crate and webview2-com-sys bindings

* Initial port to webview2-com-sys

* Finish conversion and remove winapi

* Fix renamed lint warning

* Fix all match arms referencing const variables

* Put back the assert instead of expect

* Point to the published version of webview2-com-sys

* Cleanup slightly weird BOOL handling

* Replace mem::zeroed with Default::default

* Add a summary in .changes

* Remove extra projects not in config.json

* Fix clippy warnings

* Update to 32-bit compatible webview2-com-sys

* Better fix for merge conflict

* Fix clippy errors on Windows

* Use path prefix to prevent variable shadowing

* Fix Windows clippy warnings with nightly toolchain

* Fix Linux nightly/stable clippy warnings

* Fix macOS nightly/stable clippy warnings

* Put back public *mut libc::c_void for consistency

* Re-run cargo fmt

* Move call_default_window_proc to util mod

* Remove unnecessary util::to_wstring calls

* Don't repeat LRESULT expression in match arms

* Replace bitwise operations with util functions

* Cleanup more bit mask & shift with util fns

* Prefer from conversions instead of as cast

* Implement get_xbutton_wparam

* Use *mut libc::c_void for return types

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(keyboard): add mapping for space key on Windows (rust-windowing#209)

* fix(keyboard): add mapping for space key on Windows

* change file

* feat: impl Clone for EventLoopWindowTarget (rust-windowing#211)

* chore: add `on_issue_closed.yml` (rust-windowing#214)

* Update tray dependency version (rust-windowing#217)

* Delete on_issue_closed.yml (rust-windowing#221)

* refactor(linux): event loop (rust-windowing#233)

* Use crossbeam::channel

* Fix crossbeam channel import

* Add check on poll event

* Fix deadlock when unregistering shortcut on Linux (rust-windowing#230)

* Add fullscreen monitor selection support on Linux (rust-windowing#235)

* Add fullscreen monitor support on Linux

* Add change file

* Remove todo on videomode

* Fix clippy

* Update to 2021 edition (rust-windowing#236)

* Update to 2021 edition

* Fix clippy

* Add run_return on Linux (rust-windowing#237)

* Add run_return on Linux

* Add main context

* Add run_return trait on Linux (rust-windowing#238)

* Fix: rust-windowing#239 Update webview2-com and windows crates (rust-windowing#240)

* Replace webivew2-com-sys with prebuilt windows

* Use windows utility instead of direct GetLastError

* Bump windows version and add changelog

* Run cargo fmt

* Restore inverted matches macro

* Scope constants in match arms

* Fix inverted null check

* Update src/platform_impl/windows/util.rs

Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>

* Use env_logger instead of simple_logger (rust-windowing#241)

* Use env_logger instead of simple_logger

* Make clippy happy

* Cherry pick commits to next (rust-windowing#244)

* feat(macos): Add `unhide_application` method, closes rust-windowing#182 (rust-windowing#231)

* feat(macos): Add `unhide_application` method

* Update src/platform/macos.rs

Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>

* Reanme to `show_application()`

* Remove broken doc link

Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>

* feat: Allow more strings to parse to keycode (rust-windowing#229)

* feat: support accelerator key strings `,` `-` `.` `Space` `Tab` and `F13`-`F24` (rust-windowing#228)

* feat(macOS): support more accelerator key strings

* Move function keys together

* Add `,` `-` `.` `Space` `F20-F24` for Windows

* Remove support for accelerators not found in `winapi`

* Add `,` `-` `.` `Space` `F13-F24` for Linux

* Update .changes

* Add the rest for Windows

* Add the rest for Linux

* Add the rest on macOS

* Update accelerator-strings.md

* Fix git comments

Co-authored-by: Kasper <kasperkh.kh@gmail.com>
Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>

* Add redraw events on Linux (rust-windowing#245)

* Add redraw events on Linux

* Update doc of RequestRedraw Event

* Add change file

* Fix missing menu bar on borderless window (rust-windowing#247)

Credit goes to irh's work on winit commit f2de847

* refactor: improve `set_skip_taskbar` impl on Windows (rust-windowing#250)

* fix: emit errors on parsing an invalid accelerator for string, closes rust-windowing#135 (rust-windowing#252)

* chore: update comment

* fix(linux): fix focus events not firing properly (rust-windowing#253)

* fix(linux): fix focus events not firing properly

* add changelog

* chore: update focus events error message

* chore: fmt

* fix: revert windows-rs 0.28 version bump

* fix(linux): fix native menu items (rust-windowing#256)

* chore: remove examples commited by accident

* Update `ReceivedImeText` (rust-windowing#251)

* Allow receiving text without Ime on Windows

* Avoid panic todo

* Receive text without ime on mac

* Fix CursorMoved event on Linux

* Add ReceivedImeText on Linux

This only add Simple IME from GTK for now. We should add the actual IME
from system in the future.

* Fix redraw event that causes inifinite loop (rust-windowing#260)

* Fix redraw event that causes inifinite loop

* Refactor event loop

* Remove unused function

* Add doc comment on linux's run_return

* Ignore doc test on run_return

* Add non blocking iteration on Linux (rust-windowing#261)

* Docs: SystemTrayExtWindows::remove() is gone (rust-windowing#262)

Fix docs following rust-windowing#153

* Fix busy loop on Linux (rust-windowing#265)

* Update windows crate to 0.29.0 (rust-windowing#266)

* Update to windows 0.29.0

* Add change description

* Remove clippy check (rust-windowing#267)

* refactor(windows): align util function with win32 names

* chore: update PR template

* fix(linux): fire resized & moved events on min/maximize, closes rust-windowing#219 (rust-windowing#254)

* feat(linux): implement `raw_window_handle()` (rust-windowing#269)

* chore(deps): update to raw-window-handle 0.4

* add linux raw-window-handle support

* update macos/ios/android

* fix ios

* Fix core-video-sys dependency (rust-windowing#274)

* The `cocoa` crate links to AppKit, which made the symbol `CGDisplayCreateUUIDFromDisplayID` from ApplicationServices/ColorSync (which AppKit uses internally) available to us on macOS 10.8 to 10.13. (rust-windowing#275)

However, this does not work on macOS 10.7 (where AppKit does not link to ColorSync internally). Instead of relying on this, we should just link to ApplicationServices directly.

* Fix some invalid msg_send! usage (rust-windowing#276)

* Revert "Fix some invalid msg_send! usage (rust-windowing#276)" (rust-windowing#277)

This reverts commit a3a2e0cfc49ddfa8cdf65cf9870fb8e3d45b4bc0.

* Revert "The `cocoa` crate links to AppKit, which made the symbol `CGDisplayCreateUUIDFromDisplayID` from ApplicationServices/ColorSync (which AppKit uses internally) available to us on macOS 10.8 to 10.13. (rust-windowing#275)" (rust-windowing#279)

This reverts commit 6f9c468f26ddb60e29be2139397bfaf3b30eab1e.

* The `cocoa` crate links to AppKit, which made the symbol `CGDisplayCreateUUIDFromDisplayID` from ApplicationServices/ColorSync (which AppKit uses internally) available to us on macOS 10.8 to 10.13. (rust-windowing#280)

However, this does not work on macOS 10.7 (where AppKit does not link to ColorSync internally). Instead of relying on this, we should just link to ApplicationServices directly.

Co-authored-by: madsmtm <mads@marquart.dk>

* Fix some invalid msg_send! usage (rust-windowing#278)

Co-authored-by: madsmtm <mads@marquart.dk>

* Add exit code to ControlFlow::Exit (rust-windowing#281)

* Add exit code to ControlFlow::Exit

* Cargo fmt

* Add change files

Co-authored-by:  multisn8 <contact@multisamplednight.com>

* Add new_any_thread to Unix event loop (rust-windowing#282)

* Update windows crate to 0.30.0 (rust-windowing#283)

* Update windows crate to 0.30.0

* Simplify new-type usage

* Fix boxing in GWL_USERDATA

* Make sure everyone is using Get/SetWindowLongPtrW

* build the system_tray module when "ayatana" feature is enabled (rust-windowing#285)

Without those cfg feature checks, the "ayatana" feature does
actually not enable anything.

* Fix click events missing whe tray has menu (rust-windowing#291)

* Fix click events missing whe tray has menu

* Add change file

* Fix crash when tray has no menu (rust-windowing#294)

* chore: update pull request commit exmple

* fix(windows): send correct position for system tray events, closes rust-windowing#295 (rust-windowing#300)

* fix(windows): revert maximized state handling to winit impl, closes rust-windowing#193 (rust-windowing#299)

* fix(windows): revet maximized state handling to winit impl, closes rust-windowing#193

* add chanefile [skip ci]

* fix: `MenuItem::Quit` on Windows (rust-windowing#303)

* fix: `MenuItem::Close` on Windows

* use `PostQuitMessage` instead

Co-authored-by: amrbashir <amr.bashir2015@gmail.com>

* feat: v1 audit by Radically Open Security (rust-windowing#304)

* Update to gtk 0.15 (rust-windowing#288)

* Update to gtk 0.15

* Fix picky none on set_geometry_hint

* Fix CursorMoved position

Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>
Co-authored-by: Bill Avery <wravery@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Lucas Fernandes Nogueira <lucasfernandesnog@gmail.com>
Co-authored-by: Kasper <kasperkh.kh@gmail.com>
Co-authored-by: amrbashir <amr.bashir2015@gmail.com>
Co-authored-by: Jay Oster <jay@kodewerx.org>
Co-authored-by: madsmtm <mads@marquart.dk>
Co-authored-by: multisn8 <contact@multisamplednight.com>
Co-authored-by: Aurélien Jacobs <aurel@gnuage.org>
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
@Cthutu
Copy link

Cthutu commented Mar 20, 2024

Is this coming to Windows any time soon?

@madsmtm
Copy link
Member

madsmtm commented Mar 20, 2024

Probably not, unless someone implements it.

You might be able to emulate it yourself by running window.set_inner_size(...) inside of the Resized event.

Please open a new issue if you encounter problems with doing so.

@Cthutu
Copy link

Cthutu commented Mar 21, 2024

That's what I am trying out now and hoping (fingers crossed) that it will work. Just need to write the "calculate the actual size" routine!

@tetrahedron341 tetrahedron341 mentioned this issue Apr 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francesca64 francesca64

Labels
C - in progress Implementation is proceeding smoothly D - easy Likely easier than most tasks here DS - macos P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Cthutu @tomaka @francesca64 @madsmtm @siiptuo