Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows, allow to customize the name of the Window Class (current value hard coded is "Window Class") #2977

Closed
1 of 2 tasks
geraudloup opened this issue Jul 25, 2023 · 0 comments · Fixed by #2978
Closed
1 of 2 tasks

On Windows, allow to customize the name of the Window Class (current value hard coded is "Window Class") #2977

geraudloup opened this issue Jul 25, 2023 · 0 comments · Fixed by #2978
Labels
DS - windows S - enhancement Wouldn't this be the coolest?

Comments

@geraudloup
Copy link
Contributor

geraudloup commented Jul 25, 2023 •
edited
Loading

Mirror of issue opened on Tauri forks of winit : tauri-apps/tao#769

Is your feature request related to a problem? Please describe.
Currently, on Windows, all windows created by winit have the same class Window Class, it would be neet to allow for customization of the Windows' window class name. One use case: some windows custom hotkey managers leverage window class names to select windows...

Describe the solution you'd like

  • In src\platform\windows.rs add a with_window_classname
  • In src\platform_impl\windows\mod.rs, in PlatformSpecificWindowBuilderAttributes add a window_classname attribute and in impl Default for PlatformSpecificWindowBuilderAttributes add a default value for window_classname of Window Class (non breaking change)

Describe alternatives you've considered
No alternative, unless simply dumping those tools and find one using other characteristics of windows...

Would you want to assign yourself to implement this feature?

  • Yes
  • No
@geraudloup geraudloup mentioned this issue Jul 25, 2023
Closed
2 tasks
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 25, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
7cd35fc 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 25, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
1960af5 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 25, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
ebc2bed 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 25, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
ff0897a 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 25, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
6971c89 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 26, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
178ed63 
allow to customize it instead of current value hard coded "Window Class"
@geraudloup geraudloup mentioned this issue Jul 26, 2023
Merged
13 tasks
@madsmtm madsmtm added S - enhancement Wouldn't this be the coolest? DS - windows labels Jul 28, 2023
@madsmtm madsmtm linked a pull request Jul 28, 2023 that will close this issue
On Windows, set name of Window Class, closes #2977 #2978
Merged
5 tasks
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
83804fb 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
6cebf5d 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
e6819ed 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
0f1e089 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
1de3d24 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
340b936 
allow to customize it instead of current value hard coded "Window Class"
geraudloup added a commit to geraudloup/winit that referenced this issue Jul 28, 2023
@geraudloup
On Windows, set name of Window Class, closes rust-windowing#2977
c3d22ab 
allow to customize it instead of current value hard coded "Window Class"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - windows S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On Windows, set name of Window Class, closes #2977 geraudloup/winit
2 participants
@madsmtm @geraudloup