Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wayland DPI documentation #3100

Closed
mahkoh opened this issue Sep 16, 2023 · 4 comments · Fixed by #3101
Closed

Update wayland DPI documentation #3100

mahkoh opened this issue Sep 16, 2023 · 4 comments · Fixed by #3101
Labels
DS - wayland S - docs Awareness, docs, examples, etc.

Comments

@mahkoh
Copy link
Contributor

mahkoh commented Sep 16, 2023

Documentation still says that scaling is

  • per screen
  • an integer

Both haven't been true for some time.
@kchibisov kchibisov added DS - wayland S - docs Awareness, docs, examples, etc. labels Sep 16, 2023
@kchibisov
Copy link
Member

Could you link where have you found that? I find a hard time figuring out where you got this from.

@mahkoh
Copy link
Contributor Author

mahkoh commented Sep 16, 2023

https://docs.rs/winit/0.29.1-beta/winit/dpi/index.html#how-is-the-scale-factor-calculated

@kchibisov
Copy link
Member

Ah, I think in the dpi.rs file in the top level docs... Since the methods say how it's done actually and they are not integer.

kchibisov added a commit to kchibisov/winit that referenced this issue Sep 16, 2023
@kchibisov
Correct Wayland section in dpi docs
4fce04a 
Fixes rust-windowing#3100.
@kchibisov kchibisov mentioned this issue Sep 16, 2023
Merged
@kchibisov
Copy link
Member

See #3101

kchibisov added a commit to kchibisov/winit that referenced this issue Sep 16, 2023
@kchibisov
Correct Wayland section in dpi docs
c789586 
Fixes rust-windowing#3100.
kchibisov added a commit that referenced this issue Sep 16, 2023
@kchibisov
Correct Wayland section in dpi docs
e731041 
Fixes #3100.
kchibisov added a commit to kchibisov/winit that referenced this issue Oct 17, 2023
@kchibisov
Correct Wayland section in dpi docs
72f2212 
Fixes rust-windowing#3100.
kchibisov added a commit that referenced this issue Oct 21, 2023
@kchibisov
Correct Wayland section in dpi docs
27cd207 
Fixes #3100.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - wayland S - docs Awareness, docs, examples, etc.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct Wayland section in dpi docs kchibisov/winit
2 participants
@mahkoh @kchibisov