Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleanup code to web backend, mostly web-sys #1715

Merged
merged 7 commits into from
Sep 20, 2020
Merged

Add cleanup code to web backend, mostly web-sys #1715

merged 7 commits into from
Sep 20, 2020

Commits on Sep 20, 2020

  1. web-sys: Impl. event listeners removal for canvas

    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    3813240 View commit details
    Browse the repository at this point in the history

  2. web-sys: Impl. media query listeners cleanup

    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    58e1053 View commit details
    Browse the repository at this point in the history

  3. web: Emit WindowEvent::Destroyed after Window is dropped

    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    a773054 View commit details
    Browse the repository at this point in the history

  4. web-sys: Fix unload event closure being dropped early

    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    b1e9442 View commit details
    Browse the repository at this point in the history

  5. web: Impl. cleanup on ControlFlow::Exit 

    - Drops the Runner, which causes the event handler closure to be
  dropped.
- (web-sys only:) Remove event listeners from DOM.
    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    8f9e779 View commit details
    Browse the repository at this point in the history

  6. web: Do not remove canvas from DOM when dropping Window 

    The canvas was inserted by the user, so it should be up to the user
whether the canvas should be removed.
    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    15a112f View commit details
    Browse the repository at this point in the history

  7. Update changelog

    @alvinhochun
    alvinhochun committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    05a451c View commit details
    Browse the repository at this point in the history