On Wayland, log error for failure to set cursor #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: rust-windowing#1988 The inability to set the cursor using any of the named cursor files likely indicates an error in the system on which we are running. WinitPointer::set_cursor also does not have any way of returning an error so just log the error to assist users in diagnosing the problem.
|
I haven't check the last four boxes on the check list for the commit because I haven't done anything related to what is described, but I don't believe this PR needs any of the items that are listed. |
maroider
added
DS - wayland
C - waiting on maintainer
madsmtm
approved these changes
Aug 11, 2021
| } | ||
| } | ||
| error!("Failed to set cursor"); |
There was a problem hiding this comment.
Minor nit: This should maybe be a warning instead, since the system can easily continue without the cursor having been set?
There was a problem hiding this comment.
I have changed the error!() to a warn!(). This does make it a bit inconsistent with the same error as it is logged by smithay_client_toolkit::window::concept_frame, but that will likely be a non-issue if #1990 is merged (as the concept frame will be gone by then).
kchibisov
requested changes
Aug 13, 2021
Add the cursor_icon which set_cursor was trying to set to the warning message that it logs when it is unable to set any of the cursor icons it is attempting to set.
kchibisov
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1988
The inability to set the cursor using any of the named cursor files
likely indicates an error in the system on which we are running.
WinitPointer::set_cursor also does not have any way of returning an
error so just log the error to assist users in diagnosing the problem.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users