Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the EventLoopWindowTarget passed to the EventLoop::run callback live for 'static #2346

Closed
wants to merge 12 commits into from
Closed

Make the EventLoopWindowTarget passed to the EventLoop::run callback live for 'static #2346

wants to merge 12 commits into from

Commits on Jun 23, 2022

  1. Update the signatures of EventLoop::run and EventLoop::run_return

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    d5887dd View commit details
    Browse the repository at this point in the history

  2. macOS impl

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    dc98aef View commit details
    Browse the repository at this point in the history

  3. Unify impl of EventLoop::run for run_return platforms

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    4b205b5 View commit details
    Browse the repository at this point in the history

  4. Linux impl

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f8c0153 View commit details
    Browse the repository at this point in the history

  5. Windows impl

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    b8ecaa4 View commit details
    Browse the repository at this point in the history

  6. Android impl

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    59159c9 View commit details
    Browse the repository at this point in the history

  7. iOS impl

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    dea4d27 View commit details
    Browse the repository at this point in the history

  8. Web impl 

    This works by leaking the `EventLoopWindowTarget`, which isn't ideal, but isn't really an issue since only one event loop can ever be created.
    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    e8ae77a View commit details
    Browse the repository at this point in the history

  9. Update changelog

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    bd6d944 View commit details
    Browse the repository at this point in the history

  10. fmt

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    3d08f6c View commit details
    Browse the repository at this point in the history

  11. Use unwrap_or instead of match 

    clippy appeasal
    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    34937c9 View commit details
    Browse the repository at this point in the history

  12. Remove unused import on macOS

    @Liamolucko
    Liamolucko committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    35dcdf7 View commit details
    Browse the repository at this point in the history