Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce WM_PAINT messages of thread target window #2371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wusyong
Copy link
Contributor

@wusyong wusyong commented Jul 11, 2022

Fixes #2367

Since there's no comment on the issue, I would like to open a PR and give it a try. Examples are working and we can still get nonstop messages with ControlFlow::Poll if we want.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@maroider
Copy link
Member

maroider commented Jul 13, 2022

I'll be sure to have a look at this once I feel I have a better grasp of what exactly this part of the code is supposed to do. I'm afraid to touch it with my current level of understanding.

@maroider maroider added DS - windows C - waiting on maintainer A maintainer must review this code labels Jul 13, 2022
@kchibisov
Copy link
Member

Is this still an issue on the latest master?

@wusyong wusyong requested a review from msiglreith as a code owner February 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Development

Successfully merging this pull request may close these issues.

Intense WM_PAINT msg in thread_event_target_callback
3 participants