Refactor macOS to use new objc2 features
#2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
macos-refactor-unsafe
branch
2 times, most recently
from
5c72c34
to
ec25dd7
Compare
The compiler fence is safe to get rid of now since `interpretKeyEvents` takes `&mut self`
madsmtm
force-pushed
the
macos-refactor-unsafe
branch
from
ec25dd7
to
8db12b2
Compare
madsmtm
force-pushed
the
macos-refactor-unsafe
branch
from
8db12b2
to
00a809e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final part of #2427, for now. I'll still work some more on things (namely main thread safety, see #2464), but this PR is a huge step up in safety and ease-of-maintenance.
Concretely:
appkitmodule that exposes a safe API around (almost) all message sendingobjc2's ivar mechanism, which is just magnitudes better than thewith_statefunctions we did beforeobjc2::foundationwhich contains safe interfaces to common stuff likeNSString,NSArray, ...cocoadependencyChecklist: