Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable instant/wasm-bindgen when building for wasm32 architecture #2738

Closed

Conversation

gferon
Copy link

@gferon gferon commented Mar 13, 2023

This is the mirror change of emilk/egui#2808 to fix compilation with bazel.

@gferon gferon force-pushed the winit-wasm-bindgen-optional branch from 4f4a2ea to b8ecc00 Compare March 13, 2023 17:18
@daxpedda
Copy link
Member

While we are at it, I would like to suggest removing it completely from native builds.
There are only two places that need a cfg guard anyway:

Examples can be kept by just adding it to the dev-dependencies ... only one example anyway.

@daxpedda daxpedda added DS - web C - waiting on author Waiting for a response or another PR labels May 28, 2023
@gferon gferon closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on author Waiting for a response or another PR DS - web
Development

Successfully merging this pull request may close these issues.

2 participants