Web: Fullscreen Overhaul #3063
Merged
Web: Fullscreen Overhaul #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the fullscreen functionality.
Transient events are now recorded from all known events and from the window as well. See the specification for a list of all events that trigger transient activation.
Instead of awaiting the returned
Promise, which didn't work on Safari v<16.4, to figure out if we want to add the fullscreen request to the queue, we now listen to thefullscreenchangeevent. Which can also detect external fullscreen activation and remove the our fullscreen request from the queue.The
Element::request_fullscreen()method also included an error, which is incorrect according to the new and old spec. So I removed it, we needed our custom implementation anyway to account for catching the returnedPromise.