Update objc2 crates
#3634
Merged
Update objc2 crates
#3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/update-objc2
branch
from
18c09de to
0726ed8
Compare
Changes relevant to Winit: - `icrate` has been deprecated in favour of separate crates per framework, in our case `objc2-foundation` and `objc2-app-kit` (and in the future `objc2-ui-kit` on iOS). - Moved `MainThreadMarker::run_on_main` to free-standing function `run_on_main`. - Changed how features work, this should result in less code that we need to compile. - Enums are now real structs instead of type-aliases and free constants.
madsmtm
force-pushed
the
madsmtm/update-objc2
branch
from
0726ed8 to
be020a6
Compare
kchibisov
approved these changes
Apr 18, 2024
Well... The generated code is different, the full diff can be viewed here. But the functionality is the same. |
madsmtm
added a commit
to rust-windowing/glutin
that referenced
this pull request
Apr 18, 2024
Changes relevant to glutin: - `icrate` has been deprecated in favour of separate crates per framework, in our case `objc2-foundation` and `objc2-app-kit`. - Moved `MainThreadMarker::run_on_main` to free-standing function `run_on_main`. - Changed how features work, this should result in less code that needs to be compiled. See rust-windowing/winit#3634 for the Winit change.
madsmtm
added a commit
to rust-windowing/glutin
that referenced
this pull request
Apr 18, 2024
Changes relevant to glutin: - `icrate` has been deprecated in favour of separate crates per framework, in our case `objc2-foundation` and `objc2-app-kit`. - Moved `MainThreadMarker::run_on_main` to free-standing function `run_on_main`. - Changed how features work, this should result in less code that needs to be compiled. See rust-windowing/winit#3634 for the Winit change.
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes relevant to Winit:
icratehas been deprecated in favour of separate crates per framework, in our caseobjc2-foundationandobjc2-app-kit(and in the futureobjc2-ui-kiton iOS).MainThreadMarker::run_on_mainto free-standing functionrun_on_main.Bit*operations on them, tracking that in Implementbitflags!-like traits forNS_OPTIONSenums madsmtm/objc2#602.If possible, then I'd like to get this in before
v0.30, as I'd like to move users away fromicrateas quickly as possible (it's harder for me to release fixes to that crate). (Also, this is what's failing our CI, since i deprecated a bunch of stuff inicrate).