Don't set the background color when initializing with transparency #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/macos-background-color
branch
from
6cc5499 to
a12af15
Compare
Setting the background color changes how the window title bar appears, which is something that the application should customize itself if it wants this behaviour (and also, it wasn't set when calling `set_transparent`, so the behaviour wasn't consistent).
madsmtm
force-pushed
the
madsmtm/macos-background-color
branch
from
a12af15 to
f8baa5e
Compare
kchibisov
approved these changes
Apr 27, 2024
kchibisov
pushed a commit
that referenced
this pull request
Apr 27, 2024
…3657) Setting the background color changes how the window title bar appears, which is something that the application should customize itself if it wants this behaviour (and also, it wasn't set when calling `set_transparent`, so the behaviour wasn't consistent).
madsmtm
added a commit
to madsmtm/alacritty
that referenced
this pull request
Jun 6, 2024
We set the transparency explicitly using `Window::set_transparent` further below, so this is no longer needed on macOS after: rust-windowing/winit#3657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the background color changes how the window title bar appears, which is something that the application should customize itself if it wants this behaviour (and also, it wasn't set when calling
set_transparent, so the behaviour wasn't consistent).This was introduced all the way back in #853, so I can't really tell what the reasoning behind it was, but I assume it was for the examples to show better (i.e. setting the window as transparent worked even when not rendering into it).
changelogmodule if knowledge of this change could be valuable to usersRelated: alacritty/alacritty#7928