Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atypical targets to CI #3751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+123 −0
Open

Add atypical targets to CI #3751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce950d
ci: Add atypical targets to CI
notgull Jun 23, 2024
c7bac55
m: Indicate we do not support illumos
notgull Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its actually more performant to split these into multiple steps, or use a matrix in this case, I believe.

Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,124 @@ jobs:
~/.cargo/git/db/
key: cargo-${{ matrix.toolchain }}-${{ matrix.platform.name }}-${{ hashFiles('Cargo.lock') }}

tier2:
name: Check winit for Tier 2 Targets
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
toolchain: [stable, nightly, '1.73']

steps:
- uses: taiki-e/checkout-action@v1

- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.toolchain }}

- name: Use specific dependency versions for Rust 1.63 compatibility.
if: matrix.rust == '1.63'
run: |
cargo update --package=dashmap --precise 5.4.0
cargo update --package=regex --precise=1.9.0
cargo update --package=half --precise=2.2.1

- run: >
rustup target add
x86_64-unknown-linux-musl
x86_64-unknown-linux-gnux32
x86_64-linux-android
i686-linux-android
x86_64-unknown-freebsd
x86_64-unknown-netbsd
x86_64-unknown-illumos
i686-unknown-linux-musl
riscv64gc-unknown-linux-gnu
aarch64-unknown-linux-gnu
aarch64-unknown-linux-musl
powerpc64le-unknown-linux-gnu
armv5te-unknown-linux-gnueabi
s390x-unknown-linux-gnu
arm-linux-androideabi
sparc64-unknown-linux-gnu
sparcv9-sun-solaris

- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-musl
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-musl --no-default-features --features x11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why are we using --release?
  • The output of -vv seems to make the outout quiet hard to parse to me.
  • Why --all-targets? What exactly are we testing in this case?

- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-musl --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-gnux32
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-gnux32 --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-linux-gnux32 --no-default-features --features wayland
# TODO: Figure out best way to check Android targets.
# - run: cargo check --release -vv --all-targets --target=x86_64-linux-android --features android-native-activity
# - run: cargo check --release -vv --all-targets --target=x86_64-linux-android --features android-game-activity
# - run: cargo check --release -vv --all-targets --target=i686-linux-android --features android-native-activity
# - run: cargo check --release -vv --all-targets --target=i686-linux-android --features android-game-activity
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-freebsd
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-freebsd --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-freebsd --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-netbsd
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-netbsd --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=x86_64-unknown-netbsd --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=i686-unknown-linux-musl
- run: cargo check --release -vv --all-targets --target=i686-unknown-linux-musl --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=i686-unknown-linux-musl --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=riscv64gc-unknown-linux-gnu
- run: cargo check --release -vv --all-targets --target=riscv64gc-unknown-linux-gnu --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=riscv64gc-unknown-linux-gnu --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-gnu
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-gnu --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-gnu --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-musl
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-musl --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=aarch64-unknown-linux-musl --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=powerpc64le-unknown-linux-gnu
- run: cargo check --release -vv --all-targets --target=powerpc64le-unknown-linux-gnu --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=powerpc64le-unknown-linux-gnu --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=armv5te-unknown-linux-gnueabi
- run: cargo check --release -vv --all-targets --target=armv5te-unknown-linux-gnueabi --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=armv5te-unknown-linux-gnueabi --no-default-features --features wayland
- run: cargo check --release -vv --all-targets --target=s390x-unknown-linux-gnu
- run: cargo check --release -vv --all-targets --target=s390x-unknown-linux-gnu --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=s390x-unknown-linux-gnu --no-default-features --features wayland
# - run: cargo check --release -vv --all-targets --target=arm-linux-androideabi --features android-native-activity
# - run: cargo check --release -vv --all-targets --target=arm-linux-androideabi --features android-game-activity
- run: cargo check --release -vv --all-targets --target=sparc64-unknown-linux-gnu
- run: cargo check --release -vv --all-targets --target=sparc64-unknown-linux-gnu --no-default-features --features x11
- run: cargo check --release -vv --all-targets --target=sparc64-unknown-linux-gnu --no-default-features --features wayland

tier3:
name: Check winit for Tier 3 Targets
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
toolchain: [nightly]

steps:
- uses: taiki-e/checkout-action@v1

- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.toolchain }}

- run: rustup component add rust-src
- run: cargo check -Z build-std -vv --target x86_64-unknown-openbsd --all-targets
- run: cargo check -Z build-std -vv --target x86_64-unknown-openbsd --all-targets --no-default-features --features x11
- run: cargo check -Z build-std -vv --target x86_64-unknown-openbsd --all-targets --no-default-features --features wayland
- run: cargo check -Z build-std -vv --target mips64-openwrt-linux-musl --all-targets
- run: cargo check -Z build-std -vv --target mips64-openwrt-linux-musl --all-targets --no-default-features --features x11
- run: cargo check -Z build-std -vv --target mips64-openwrt-linux-musl --all-targets --no-default-features --features wayland
- run: cargo check -Z build-std -vv --target sparc-unknown-linux-gnu --all-targets
- run: cargo check -Z build-std -vv --target sparc-unknown-linux-gnu --all-targets --no-default-features --features x11
- run: cargo check -Z build-std -vv --target sparc-unknown-linux-gnu --all-targets --no-default-features --features wayland
- run: cargo check -Z build-std -vv --target aarch64-unknown-linux-gnu_ilp32 --all-targets
- run: cargo check -Z build-std -vv --target aarch64-unknown-linux-gnu_ilp32 --all-targets --no-default-features --features x11
- run: cargo check -Z build-std -vv --target aarch64-unknown-linux-gnu_ilp32 --all-targets --no-default-features --features wayland
- run: cargo check -Z build-std -vv --target x86_64-uwp-windows-msvc --all-targets

cargo-deny:
name: Run cargo-deny on ${{ matrix.platform.name }}
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions src/platform_impl/linux/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
#[cfg(all(not(x11_platform), not(wayland_platform)))]
compile_error!("Please select a feature to build for unix: `x11`, `wayland`");

#[cfg(any(target_os = "solaris", target_os = "illumos"))]
compile_error! {
"winit does not support Solarish operating systems."
}

use std::collections::VecDeque;
use std::os::unix::io::{AsFd, AsRawFd, BorrowedFd, RawFd};
use std::sync::Arc;
Expand Down
Loading