Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine function names and type signatures #886

Merged
merged 23 commits into from
May 30, 2019
Merged

Refine function names and type signatures #886

merged 23 commits into from
May 30, 2019

Commits on May 26, 2019

  1. First name consistency pass. More to come!

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    f627664 View commit details
    Browse the repository at this point in the history

  2. Remove multitouch variable (hopefully this compiles!)

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    e823983 View commit details
    Browse the repository at this point in the history

  3. Remove CreationError::NotSupported

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    6ef9fe4 View commit details
    Browse the repository at this point in the history

  4. Add new error handling types

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    00d1d6b View commit details
    Browse the repository at this point in the history

  5. Remove get_ prefix from getters. 

    This is as per the Rust naming conventions recommended in
https://rust-lang-nursery.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter
    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    3e7d622 View commit details
    Browse the repository at this point in the history

  6. Make changes to Window position and size function signatures

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    45b941b View commit details
    Browse the repository at this point in the history

  7. Remove CreationError in favor of OsError

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    61e2812 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'eventloop-2.0' into functions-renamed

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    7463157 View commit details
    Browse the repository at this point in the history

  9. Begin updating iOS backend

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    39ce524 View commit details
    Browse the repository at this point in the history

  10. Change MonitorHandle::outer_position to just position

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    c0fa938 View commit details
    Browse the repository at this point in the history

  11. Fix build on Windows and Linux

    @Osspial
    Osspial committed May 26, 2019
    Configuration menu
    Copy the full SHA
    192a28e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Add Display and Error implementations to Error types

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    ac4d5bf View commit details
    Browse the repository at this point in the history

  2. Attempt to fix iOS build. 

    I can't actually check that this works since I can't cross-compile to
iOS on a Windows machine (thanks apple :/) but this should be one of
several commits to get it working.
    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    ecce663 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix iOS errors, and muck up Travis to make debugging easier

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    21077bd View commit details
    Browse the repository at this point in the history

  4. More iOS fixins

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    c4cb1e6 View commit details
    Browse the repository at this point in the history

  5. Add Debug and Display impls to OsError

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    288c8a2 View commit details
    Browse the repository at this point in the history

  6. Fix Display impl

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    5b477a7 View commit details
    Browse the repository at this point in the history

  7. Fix unused code warnings and travis

    @Osspial
    Osspial committed May 28, 2019
    Configuration menu
    Copy the full SHA
    deb56cf View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Rename set_ime_spot to set_ime_position

    @Osspial
    Osspial committed May 29, 2019
    Configuration menu
    Copy the full SHA
    7b41bae View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry

    @Osspial
    Osspial committed May 29, 2019
    Configuration menu
    Copy the full SHA
    ecc77f7 View commit details
    Browse the repository at this point in the history

  3. Rename set_cursor to set_cursor_icon and MouseCursor to CursorIcon

    @Osspial
    Osspial committed May 29, 2019
    Configuration menu
    Copy the full SHA
    7803a4f View commit details
    Browse the repository at this point in the history

  4. Organize Window functions into multiple, categorized impls

    @Osspial
    Osspial committed May 29, 2019
    Configuration menu
    Copy the full SHA
    c3fa2cd View commit details
    Browse the repository at this point in the history

  5. Improve clarity of function ordering and docs in EventLoop

    @Osspial
    Osspial committed May 29, 2019
    Configuration menu
    Copy the full SHA
    7126ad6 View commit details
    Browse the repository at this point in the history