-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make setting LogicalPosition
and LogicalSize
values generic over Into
conversions
#901
Conversation
Can this be rebased off the eventsloop-v2 branch? |
Checks seem to be failing since I changed the base branch on GitHub after I pushed the new changes. |
It couldn't be merged before you changed the destination branch. Try pushing another commit to trigger the build again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this compile on linux.
This PR seems to have a lot of overlap with #895, which does more comprehensive changes to the DPI API. |
The intention of this PR is to make it possible to just convert from tuples. Since logical values are what are usually used, it may make sense to implement |
I'm not inclined to implement that conversion, since that implies that there's a "right" way to convert between an untyped coordinate pair and a physical or logical coordinate pair. However, there isn't - one of the reasons for switching to that design is explicitly to de-opinionate Winit in regards to physical/logical coordinate space. Logical and physical coordinate each have their use-cases, and it's been demonstrated that asserting a one-size-fits-all solution will only irritate our users. Enabling |
With that stated, I'm going to close this PR |
This allows for doing:
CHANGELOG.md
if knowledge of this change could be valuable to usersUpdated documentation to reflect any user-facing changes, including notes of platform-specific behaviorCreated an example program if it would help users understand this functionalityUpdated feature matrix, if new features were added or implemented