Add translations of 3DS result macros + debug impl #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-h-chamberlain
force-pushed
the
errors/split-and-debug
branch
from
020f7a7
to
92c37b0
Compare
AzureMarker
reviewed
Feb 1, 2022
Meziu
approved these changes
Feb 1, 2022
AzureMarker
reviewed
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @AzureMarker pointed out, we can use these to decode error return values from the libctru APIs. I also added a little more info to the
Debugimpl forctru_rs::Resultwhich should help debugging a bit in some cases.See https://github.com/devkitPro/libctru/blob/master/libctru/include/3ds/result.h for the original definitions, which I assume are not generated by
bindgensince they are macros and not simple#defines.I intend to use these in rust3ds/shim-3ds#8 to translate from libctru codes to
errnovalues, and make thegetrandombehavior closer to spec.