Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling the cache feature #22

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix disabling the cache feature #22

merged 3 commits into from
Jul 29, 2024

Conversation

viperML
Copy link
Contributor

@viperML viperML commented Jul 16, 2024

The #[cfg] only applies to the following line. Othewise, building without the feature yields:

$ cargo build --no-default-features
    Updating crates.io index
   Compiling libc v0.2.155
   Compiling uzers v0.12.0 (/home/ayats/Documents/uzers-rs)
error[E0432]: unresolved import `cache`
   --> src/lib.rs:151:9
    |
151 | pub use cache::UsersSnapshot;
    |         ^^^^^ maybe a missing crate `cache`?
    |
    = help: consider adding `extern crate cache` to use the `cache` crate

For more information about this error, try `rustc --explain E0432`.
error: could not compile `uzers` (lib) due to 1 previous error

viperML and others added 3 commits July 29, 2024 07:24
Signed-off-by: Fernando Ayats <ayatsfer@gmail.com>
…atures

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the commit message to conform convco and fixed the other unrelated CI issues.

LGTM! Thanks!

@gierens gierens merged commit 81b892f into rustadopt:main Jul 29, 2024
5 checks passed
@viperML
Copy link
Contributor Author

viperML commented Jul 29, 2024

Thank you

@gierens
Copy link
Member

gierens commented Jul 29, 2024

I'll probably put it in a 0.12.1 release later the day.

@gierens
Copy link
Member

gierens commented Aug 3, 2024

Released ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants