[more] implementation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgarzik ready for review 🫡 |
jgarzik
requested changes
Nov 3, 2024
.github/workflows/TestingCI.yml
Outdated
| @@ -2,6 +2,8 @@ name: Rust | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - more | |||
There was a problem hiding this comment.
This change leaked in from development branch?
This PR should not update TestingCI.yml at all, AFAICS.
.gitignore
Outdated
| @@ -1,3 +1,2 @@ | |||
|
|
|||
| target/ | |||
There was a problem hiding this comment.
This PR should not update .gitignore at all?
display/more.rs
Outdated
|
|
||
| /// more - display files on a page-by-page basis. | ||
| #[derive(Parser)] | ||
| #[command(version, about = "more - display files on a page-by-page basis")] |
There was a problem hiding this comment.
The string constant should be wrapped inside a gettext() call
display/more.rs
Outdated
| #[command(version, about = "more - display files on a page-by-page basis")] | ||
| struct Args { | ||
| // Enable interactive session test | ||
| #[arg(long = "test", help = "Enable interactive session test.")] |
There was a problem hiding this comment.
Ditto for all help = "xxx" should be help = gettext("xxx")
|
@jgarzik fixed. please review |
jgarzik
requested changes
Nov 8, 2024
.github/workflows/TestingCI.yml
Outdated
| @@ -44,4 +44,4 @@ jobs: | |||
| - name: Build | |||
| run: cargo build --release --verbose | |||
| - name: Run tests | |||
| run: cargo test --release --verbose | |||
| run: cargo test --release --verbose | |||
There was a problem hiding this comment.
This file should not be touched by this PR.
display/Cargo.toml
Outdated
| gettext-rs.workspace = true | ||
| libc = { version = "0.2", default-features = false } |
There was a problem hiding this comment.
this should be libc.workspace.
display/more.rs
Outdated
|
|
||
| /// more - display files on a page-by-page basis. | ||
| #[derive(Parser)] | ||
| #[command(version, about = "more - display files on a page-by-page basis")] |
|
@jgarzik done. please check |
jgarzik
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.