-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter-buid: Parameterize Android builds for easier debug release switch in mirror repos #8907
Conversation
1932f55
to
84ebd8e
Compare
I do not want to publish debug versions in our release to confuse users. Please disable it in our release. Users who want it can build themself with the CI. |
cb614b0
to
af8a19f
Compare
I understand that, but maybe make separate release like
|
B&R is really needed :( |
@rustdesk ^^ |
These are adavanced users, building CI is not hard for them. |
Yep but maintaining the repo is :) TBH I am not sure Github actions allows to pick only android action from whole flutter build to reproduce official bukld (certs apart ofc) |
Maybe (as bare minimum) keep these signed debug builds as artifacts but not let them go in release? |
You can add a secret variable to turn it on. then user can turn it on to build on their repo. |
As @rustdesk noted debug builds are no-go in official RD repo but this change makes it possible to filter jobs only relevant to Android from flutter-build.yml to build only Android in a separate mirror of Rustdesk. Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
af8a19f
to
d25a157
Compare
@rustdesk OK I dropped debug builds completely but I would like to have the parameterized build matrix merged because I figured how to transform vanilla |
TL;DR: It is possible to estabilish the mirror of Rustdesk repo, set up GH action to create a separate yaml that contains only Android-related action definitions and trigger it with CI. |
armv7 android failed, :( |
Likely a flake, if it bangs 2nd time I will check :) |
I retried, still failed |
Just retried again, seems working. |
There must be something we did wrong, https://github.com/rustdesk/rustdesk/actions/runs/10208438546/job/28244926845 |
Can it be GHA runner cache issue? Because I explicitly set another CI and have got this first and then healed |
@rustdesk I found the source of flake.. it is ndk's r27 (clang 18) not playing well with CMake 3.30 (vcpkg still wants 3.29 so idk where did it get from):
Also vcpkg did save built libs in cache but never used them to speed up subsequent builds thanks to counter-intuitive Will PR the fix after I understand what to do. |
No description provided.