-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lifetime bounds in higher-ranked lifetimes #62
Conversation
Those bounds are ignored by the compiler, and will soon trigger an error. According to crater, this is the only crate using these bounds.
Thanks! Bors r+ |
62: Remove lifetime bounds in higher-ranked lifetimes r=Rhuagh a=RalfJung Those bounds are ignored by the compiler, and will trigger an error once rust-lang/rust#48326 lands. According to crater, this is the only crate using these bounds. This patch should make the crate work on nightly again. However, I have been unable to compile the crate even with nightly 2018-02-25, which does not include the change mentioned above. So, I couldn't compile-test this PR. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rustgd/rhusics/62) <!-- Reviewable:end -->
We'll see if it builds on CI :) |
Build succeeded |
Looks like it works there atleast |
The build failure was caused by rust-lang/rust#48551. That's fixed, but my branch where I develop rust-lang/rust#48326 does not include the fix yet, so I can't test whether this will keep working when my patch lands. However, these are all the occurrences of higher-ranked lifetime bounds that crater found. Thanks for merging so quickly. :) Please release a new minor version of the create before the patch hits stable (which will take ~9 weeks). |
We will probably release a new major version before that (we have some breaking changes). |
AFAIK a new minor version with the fix would be necessary for reverse dependencies that will just do |
True, I'll get that out tonight. |
I compiled rustc with my patch merged into master, and can confirm that this can build current rhusics master (while it fails on the version without my patch, as expected). So, looking good :) |
The breaking changes had not been merged to master yet, so this was easier than I thought it would :) Anyways, new minors have been released. |
Those bounds are ignored by the compiler, and will trigger an error once rust-lang/rust#48326 lands. According to crater, this is the only crate using these bounds. This patch should make the crate work on nightly again.
However, I have been unable to compile the crate even with nightly 2018-02-25, which does not include the change mentioned above. So, I couldn't compile-test this PR.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)