Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file out of sync #1204

Closed
alerque opened this issue Aug 22, 2024 · 1 comment · Fixed by #1207
Closed

Lock file out of sync #1204

alerque opened this issue Aug 22, 2024 · 1 comment · Fixed by #1207
Labels
S-triage Status: Waiting for a maintainer to triage this issue/PR

Comments

@alerque
Copy link
Contributor

alerque commented Aug 22, 2024

The v0.8.0 version bump got set in the manifest, but the lock file is out of sync. This means the app will not build in --locked mode. I'm trying to bump the Arch Linux package, but this is causing the build to fail. We could fudge and generate our own, but then we wouldn't be using anything consistent across distros and our own package wouldn't be reproducible.

Can you please consider updating the lock file and putting out a patch release? In the future make sure you bump both the lock file and manifest together when changing the release version. Thanks.

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Aug 22, 2024
@aawsome
Copy link
Member

aawsome commented Aug 22, 2024

Thanks @alerque for opening this issue!

In fact we are trying to automate the releasing more and more. While trying to use more automation I did not run a cargo build locally anymore to see if it makes changes in the lock file... I think we'll add a locked build to the release pipeline to check for this kind of problem in future...

Anyway, yes, we can do a patch release. I would like to wait for a couple of days if other problems show up and then do another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: Waiting for a maintainer to triage this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants