Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add s3_idrive config and move configs to a services subdirectory #1048

Merged
merged 9 commits into from
Feb 5, 2024
Merged

feat(config): add s3_idrive config and move configs to a services subdirectory #1048

merged 9 commits into from
Feb 5, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Feb 4, 2024 •
edited
Loading

To documents working toml for iDrive S3.

Discussed here: #1044 (reply in thread)

Supercedes: #1046

kapitainsky and others added 2 commits February 4, 2024 18:18
@kapitainsky
Create S3_iDrive.toml
f5b5b24 
To documents working toml for iDrive S3.

Discussed here: #1044 (reply in thread)
@simonsan
feat(config): update config files
03fc72c 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan added C-enhancement Category: New feature or request A-ui-ux Area: Related to user interfaces and user experience A-config Area: Related to the config file functionality and format labels Feb 4, 2024
@simonsan
docs: add section to documentation about the services
b966cfe 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan
refactor: s3 config to opendal syntax
1c51cb2 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan
docs: add comment to s3 that explicit region is better than auto for …
5bf792a 
…latency

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan requested a review from aawsome February 4, 2024 19:22
@simonsan
feat(config): add sftp for hetzner storage box
588d4ee 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
aawsome
aawsome requested changes Feb 4, 2024
View reviewed changes
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly fine, but for S3 (AWS) I would change the config according to the opendal docu.

Maybe also change the filename to s3_aws.toml?

config/services/s3.toml Outdated Show resolved Hide resolved
config/services/s3.toml Outdated Show resolved Hide resolved
@simonsan
Merge branch 'main' into pr/kapitainsky/1046
8d46c63
@simonsan
fix: apply suggestions from review
324f2a9 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan requested a review from aawsome February 4, 2024 23:41
aawsome
aawsome approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aawsome aawsome enabled auto-merge February 5, 2024 07:29
@aawsome aawsome added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit ef4fd52 Feb 5, 2024
25 checks passed
@aawsome aawsome deleted the pr/kapitainsky/1046 branch February 5, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johansmitsnl johansmitsnl johansmitsnl left review comments

@kapitainsky kapitainsky kapitainsky left review comments

@aawsome aawsome aawsome approved these changes

Assignees
No one assigned
Labels
A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonsan @johansmitsnl @kapitainsky @aawsome