Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUSTSEC-2024-0384: instant is unmaintained #351

Closed
github-actions bot opened this issue Nov 11, 2024 · 3 comments · Fixed by #356
Closed

RUSTSEC-2024-0384: instant is unmaintained #351

github-actions bot opened this issue Nov 11, 2024 · 3 comments · Fixed by #356
Labels
A-dependencies Area: Related to updating dependencies C-refactor Category: Refactoring of already existing code

Comments

@github-actions
Copy link
Contributor

instant is unmaintained

Details
Status unmaintained
Package instant
Version 0.1.13
URL
Date 2024-09-01

This crate is no longer maintained, and the author recommends using the maintained web-time crate instead.

See advisory page for additional details.
@simonsan
Copy link
Contributor

Used by backoff in rustic_backend, we wanted to refactor to backon afair.

@simonsan simonsan added A-dependencies Area: Related to updating dependencies C-refactor Category: Refactoring of already existing code labels Nov 11, 2024
@simonsan
Copy link
Contributor

Affects:

  • rustic_scheduler
  • rustic-rs

@simonsan
Copy link
Contributor

Used by backoff in rustic_backend, we wanted to refactor to backon afair.

https://github.com/Xuanwo/backon

@simonsan simonsan mentioned this issue Nov 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024
@nardoor @aawsome @simonsan
refactor(backend): migrate from backoff to backon (#356)
80892c5 
Hello,

Removed the unmaintained  `backoff` crate in the `rustic_backend` crate.
Replaced it with the relatively similar `backon` crate.

If `backon` as simpler API, it also lacks a few features that `backoff`
had.
For instance: `no_max_delay` or `backoff::retry_notify`. 
To make up for it:
- I opened Xuanwo/backon#160 on the `backon`
github.
- I implemented an internal module `backon_extension` inside
`backend::rest`.

Let me know what you think of the code!

Fixes #351

---------

Co-authored-by: Alexander Weiss <alex@weissfam.de>
Co-authored-by: simonsan <14062932+simonsan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Related to updating dependencies C-refactor Category: Refactoring of already existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(backend): migrate from backoff to backon nardoor/rustic_core
1 participant
@simonsan