Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow specifying many options in config profile without array #211

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Apr 22, 2024

Adds the possibility to specify many options in config profile files as single strings which required arrays of strings - in the case of the array only containing 1 entry.

Breaking change:
Also removes the splitting of one string from password-command and warmup-command. Now the already-split command has to be given as array (or single string if there are no arguments to the command).

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 28.0%. Comparing base (7535ea3) to head (5a9b0d7).

Additional details and impacted files
Files Coverage Δ
crates/core/src/backend/ignore.rs 50.0% <ø> (+0.3%) ⬆️
crates/core/src/commands/forget.rs 0.0% <ø> (ø)
crates/core/src/error.rs 14.2% <ø> (ø)
crates/core/src/repofile/snapshotfile.rs 20.0% <75.0%> (+0.2%) ⬆️
crates/core/src/repository/warm_up.rs 0.0% <0.0%> (ø)
crates/core/src/repository.rs 25.6% <12.5%> (-0.1%) ⬇️

... and 10 files with indirect coverage changes

@aawsome aawsome merged commit 4798228 into main Apr 22, 2024
32 of 33 checks passed
@aawsome aawsome deleted the oneormany branch April 22, 2024 10:16
@simonsan simonsan mentioned this pull request Apr 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 18, 2024
## 🤖 New release
* `rustic_backend`: 0.1.1 -> 0.2.0 (✓ API compatible changes)
* `rustic_core`: 0.2.0 -> 0.3.0 (✓ API compatible changes)
* `rustic_config`: 0.1.0 -> 0.2.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.2.0](rustic_backend-v0.1.1...rustic_backend-v0.2.0)
- 2024-08-18

### Added
- *(backends)* Add throttle option to opendal backend
([#216](#216))
- *(backend)* [**breaking**] remove s3 and sftp wrapper around opendal
([#200](#200))
- [**breaking**] move clippy lints to cargo manifest and fix upcoming
issues all over the workspace
([#176](#176))
- *(opendal)* Add option connections
([#155](#155))

### Fixed
- clippy lints
([#220](#220))
- *(backends)* local: Only create repo dir when creating the repository
([#206](#206))
- *(deps)* update rust crate reqwest to 0.11.26
([#196](#196))
- *(deps)* update rust crate thiserror to 1.0.58
([#192](#192))
- *(deps)* update rust crate anyhow to 1.0.81
([#191](#191))
- *(rclone)* Use semver for version checking
([#188](#188))
- *(deps)* update rust crate clap to 4.5.2
([#183](#183))
- *(config)* Merge repository options for multiple config sources
([#171](#171))
- *(backend)* Give useful error message when no repository is given.
- updated msrv and fix clippy lints
([#160](#160))

### Other
- dependency updates
- *(deps)* more version updates
([#237](#237))
- Update MSRV to 1.76.0
- *(deps)* Several version updates
([#234](#234))
- Update MSRV (needed by opendal)
- update opendal to 0.46 and refactor accordingly
([#225](#225))
- Update MSRV to 1.73.0
- fix clippy lints
- *(deps)* update dependencies
([#180](#180))
- add rustic_testing to workspace crates
- reset again after release to workspace dependencies for workspace
crates
</blockquote>

## `rustic_core`
<blockquote>

##
[0.3.0](rustic_core-v0.2.0...rustic_core-v0.3.0)
- 2024-08-18

### Added
- *(forget)* [**breaking**] Make keep-* Options and add keep-none
([#238](#238))
- add search methods to Repository
([#212](#212))
- [**breaking**] Allow specifying many options in config profile without
array ([#211](#211))
- [**breaking**] move clippy lints to cargo manifest and fix upcoming
issues all over the workspace
([#176](#176))
- Add extra check before writing data
([#154](#154))
- Allow missing fields in snapshot summary
- Hide plain text password from help text
([#170](#170))
- Add Repository::to_indexed_checked and ::to_index_ids_checked()
([#168](#168))
- *(prune)* Add more debug info to stats
([#162](#162))
- Add append-only repository mode
([#164](#164))

### Fixed
- parse commands given by arg or env using shell_words
([#240](#240))
- Allow non-value/null xattr
([#235](#235))
- ensure Rust 1.76.0 compiles
- backup file even if failed listing extended attributes
([#233](#233))
- Export types so the Repository type can be fully specified
([#229](#229))
- Always sort StringList
([#226](#226))
- *(commands)* Properly finish progress bars
- *(commands)* [**breaking**] Fix edge case for repair index
([#219](#219))
- clippy lints
([#220](#220))
- *(errors)* Show filenames in error message coming from ignore source
([#215](#215))
- *(paths)* Handle paths starting with "." correctly
([#213](#213))
- Add warning about unsorted files and sort where neccessary
([#205](#205))
- *(deps)* update rust crate thiserror to 1.0.58
([#192](#192))
- *(deps)* update rust crate anyhow to 1.0.81
([#191](#191))
- *(deps)* update rust crate serde_with to 3.7.0
([#189](#189))
- *(rclone)* Use semver for version checking
([#188](#188))
- *(deps)* update rust crate strum to 0.26.2
([#187](#187))
- *(deps)* update rust crate clap to 4.5.2
([#183](#183))
- Set correct content for symlink with parent snapshot
([#174](#174))
- update dependency nix
([#169](#169))
- *(memory)* Limit memory usage for restore when having large pack files
([#165](#165))
- *(prune)* Correct number of repacks
([#167](#167))
- updated msrv and fix clippy lints
([#160](#160))

### Other
- dependency updates
- Ensure that MSRV 1.76 works
- *(deps)* more version updates
([#237](#237))
- Update MSRV to 1.76.0
- *(deps)* Several version updates
([#234](#234))
- fix clippy lints
([#236](#236))
- Update MSRV (needed by opendal)
- update sha2 dependency
- add integration tests for `prune` and `ls`
([#221](#221))
- *(error)* Add error sources
([#217](#217))
- add more warnings
- make SnapshotFile::cmp_group public
([#210](#210))
- Update MSRV to 1.73.0
- fix clippy lints
- add backup integration tests using snapshots
([#175](#175))
- replace dep bitmask-enum by enumset
([#173](#173))
- *(deps)* update dependencies
([#180](#180))
- use release-plz action, remove public api fixtures incl. test and
related ci and other release related ci
- Add unit tests for extra verification
([#172](#172))
- rustic_config v0.1.0
- add rustic_testing to workspace crates
</blockquote>

## `rustic_config`
<blockquote>

##
[0.2.0](rustic_config-v0.1.0...rustic_config-v0.2.0)
- 2024-08-18

### Added
- [**breaking**] move clippy lints to cargo manifest and fix upcoming
issues all over the workspace
([#176](#176))

### Other
- Update MSRV to 1.76.0
- Update MSRV (needed by opendal)
- Update MSRV to 1.73.0
- add changelog for rustic_config
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant