Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't give invalid password error for other keyfile errors #247

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Aug 26, 2024

No description provided.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.0%. Comparing base (8c19c93) to head (fed273a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/repofile/keyfile.rs 50.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/error.rs 57.1% <ø> (+57.1%) ⬆️
crates/core/tests/keys.rs 100.0% <100.0%> (ø)
crates/core/src/repofile/keyfile.rs 77.3% <50.0%> (+36.3%) ⬆️

... and 6 files with indirect coverage changes

@simonsan simonsan added this pull request to the merge queue Sep 6, 2024
@aawsome aawsome removed this pull request from the merge queue due to a manual request Sep 6, 2024
@aawsome aawsome merged commit 4bda67a into main Sep 6, 2024
28 checks passed
@aawsome aawsome deleted the fix-keyfile-errors branch September 6, 2024 15:17
aawsome pushed a commit that referenced this pull request Sep 6, 2024
## 🤖 New release
* `rustic_backend`: 0.2.0 -> 0.2.1 (✓ API compatible changes)
* `rustic_core`: 0.3.0 -> 0.3.1 (✓ API compatible changes)
* `rustic_testing`: 0.2.0 -> 0.2.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.2.1](rustic_backend-v0.2.0...rustic_backend-v0.2.1)
- 2024-09-06

### Added
- Add autocompletion hints
([#257](#257))

### Fixed
- Re-add missing opendal services
([#249](#249))

### Other
- Revert "backend: specify core version"
</blockquote>

## `rustic_core`
<blockquote>

##
[0.3.1](rustic_core-v0.3.0...rustic_core-v0.3.1)
- 2024-09-06

### Added
- Add autocompletion hints
([#257](#257))

### Fixed
- don't give invalid password error for other keyfile errors
([#247](#247))
- adjust tests to new Rust version
([#259](#259))
- fix FromStr for SnapshotGroupCriterion
([#254](#254))
- make more Indexed traits public
([#253](#253))
- fix StringList::contains_all
([#246](#246))
- *(build)* unbreak building on OpenBSD
([#245](#245))
</blockquote>

## `rustic_testing`
<blockquote>

##
[0.2.1](rustic_testing-v0.2.0...rustic_testing-v0.2.1)
- 2024-09-06

### Fixed
- dprint

### Other
- use rustic_core from workspace
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants