tests: support CARGO_TARGET_DIR env variable #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Dec 16, 2022
tests/tests.rs
Outdated
|
|
||
| fn client_command() -> Command { | ||
| let client_bin_path = examples_dir().join("client"); | ||
| println!("client_bin_path: {:?}", client_bin_path); |
There was a problem hiding this comment.
Can we remove the println!() call?
I'd prefer to inline target_dir() into examples_dir() and avoid the bindings in server_command() and client_command() (instead putting the examples_dir().join() directly in the Command::new() call.
djc
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests don't work if you have a custom
CARGO_TARGET_DIR