-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TlsAcceptor::with_acceptor method #221
Conversation
1b11f62
to
4a6220a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly makes sense to me. I'd prefer to keep the bounds in the impl
definition where possible (impl<C: AsyncRead + AsyncWrite + Unpin> TlsStream<c>
).
Do you have a sense of whether this is semver-compatible? If not, can you add a semver-breaking version bump in a separate commit?
Out of curiosity, what do you (want to) use instead of AddrIncoming
?
@djc thanks, I will do as suggested We're abstracting networking in our project to implement simulation with turmoil. So I have a custom acceptor that wraps a turmoil |
as for semver, I'm not completely certain. It seems to me that yes, thanks to the default types, but I'm not an expert enough on semver. |
4a6220a
to
ef66662
Compare
I think this documentation says it should be okay. |
ef66662
to
7652e4c
Compare
@djc, I fixed fmt and fixed the trait bounds 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@cpu do you want to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
This PR add a
AcceptorBuilder::with_connector
method that takes a generic acceptor implementingAccept
.This is necessary when you need to work with any other acceptor than
AddrIncomming
.