hyper-rustls 0.25 prep, rustls 0.22 update #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Dec 2, 2023
| @@ -22,9 +22,9 @@ impl AcceptorBuilder<WantsTlsConfig> { | |||
| AcceptorBuilder(WantsAlpn(config)) | |||
| } | |||
|
|
|||
| /// Use rustls [defaults][with_safe_defaults] without [client authentication][with_no_client_auth] | |||
| /// Use rustls default crypto provider and safe defaults without | |||
There was a problem hiding this comment.
I think some of these doc updates in this branch that lose the doc link to the removed with_safe_defaults would benefit from pointing at the ring::default_provider fn where we could document the safe defaults better.
I'll chase this down before merge.
|
I think we should probably take the hyper 1 update before we release this? |
djc
approved these changes
Dec 4, 2023
This commit updates to rustls 0.22, taking the following associated updates: * rustls 0.22.0-alpha-6 -> 0.22 * pki-types 0.2 -> 1 * tokio-rustls 0.25.0-alpha.4 -> 0.25 * rustls-native-certs 0.7.0-alpha.3 -> 0.7 * webpki-roots 0.26.0-alpha.2 -> 0.26 * rustls-pemfile 2.0.0-alpha.2 -> 2 Breaking API changes are addressed as required. Notably, the builder fns that accept a custom provider and use the safe defaults are now fallible to account for a possible error if the provider's configuration is not compatible with the default safe protocol versions.
|
Is there a reason for this to still be draft? |
No, I suppose we can land this and figure out the hyper 1 update and release notes separately. |
cpu
changed the title
djc
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch updates to rustls 0.22 and bumps the crate version from 0.25.0-alpha.0 to 0.25, taking the following associated updates:
Breaking API changes are addressed as required. Notably, the
with_provider_and_webpki_rootsbuilder fn that accepts a custom provider and uses the safe default protocol versions is now fallible to account for a possible error if the provider's configuration is not compatible.