Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for rustls-cng crate #6

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

MS-megliu
Copy link
Contributor

(1) store::CertStore - New find_by_sha256()
(2) signer::CngSigner – Update hash() using BCryptHash
(3) cert::Context – Update as_chain_der() to exclude root and check to use HKLM or HKCU.

new test case test_find_by_hash256() added and passed.
cargo test passed.

src/cert.rs Outdated Show resolved Hide resolved
src/cert.rs Outdated Show resolved Hide resolved
src/store.rs Outdated Show resolved Hide resolved
src/signer.rs Outdated Show resolved Hide resolved
@MS-megliu
Copy link
Contributor Author

We removed sha2 and aws-lc-rs dependency in cargo.toml as we don't see they are used. please let us know if aws-lc-rs is needed. Thanks!

Cargo.toml Show resolved Hide resolved
@ancwrd1
Copy link
Collaborator

ancwrd1 commented Dec 11, 2024

@PhilHallin if you don't have any more comments I can merge it.

@PhilHallin
Copy link

Hi Dmitry,

The changes look good to me. Megan would prefer to do some additional testing.
However, she is currently busy on another project through the end of 2024.
We will let you make the call if you want to merge now or wait until January 2025.

Thanks again for all your support.

Phil


In reply to: 2537252222

Copy link

@PhilHallin PhilHallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ancwrd1
Copy link
Collaborator

ancwrd1 commented Dec 13, 2024

I will merge it as it is now, feel free to open another PR if some issue is found.

@ancwrd1 ancwrd1 merged commit c377b43 into rustls:dev Dec 13, 2024
2 checks passed
@MS-megliu
Copy link
Contributor Author

Hi Dmitry,

Thanks very much for all your support!

Happy Holidays!
Megan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants