-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for rustls-cng crate #6
Conversation
We removed sha2 and aws-lc-rs dependency in cargo.toml as we don't see they are used. please let us know if aws-lc-rs is needed. Thanks! |
@PhilHallin if you don't have any more comments I can merge it. |
Hi Dmitry, The changes look good to me. Megan would prefer to do some additional testing. Thanks again for all your support. Phil In reply to: 2537252222 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge it as it is now, feel free to open another PR if some issue is found. |
Hi Dmitry, Thanks very much for all your support! Happy Holidays! |
(1) store::CertStore - New find_by_sha256()
(2) signer::CngSigner – Update hash() using BCryptHash
(3) cert::Context – Update as_chain_der() to exclude root and check to use HKLM or HKCU.
new test case test_find_by_hash256() added and passed.
cargo test passed.