Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track rustls alpha.6 #368

Merged
merged 1 commit into from
Nov 29, 2023
Merged

track rustls alpha.6 #368

merged 1 commit into from
Nov 29, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Nov 24, 2023

Brings in the change to use pki_types for ServerName.

src/client.rs Outdated Show resolved Hide resolved
@cpu cpu mentioned this pull request Nov 24, 2023
4 tasks
Brings in the change to use `pki-types` for `ServerName`.

Takes a temporary quality-of-life patch for pki-types.
@cpu cpu changed the title WIP: track rustls alpha.5 WIP: track rustls alpha.6 Nov 29, 2023
@cpu cpu changed the title WIP: track rustls alpha.6 track rustls alpha.6 Nov 29, 2023
rustls-webpki = "0.102.0-alpha.6"
pki-types = { package = "rustls-pki-types", version = "0.2.1", features = ["std"] }
rustls = { version = "=0.22.0-alpha.6", features = [ "ring" ]}
pki-types = { package = "rustls-pki-types", version = "0.2.3", features = ["std"] }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes to 0.2.3 instead of staying at 0.2.2 because we're using the ServerName::to_str method that's only available in 0.2.3+

@cpu cpu marked this pull request as ready for review November 29, 2023 22:05
@cpu cpu requested a review from jsha November 29, 2023 22:05
Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsha jsha merged commit 49adcee into rustls:main Nov 29, 2023
21 checks passed
@cpu cpu deleted the cpu-track-rustls-main branch November 29, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants