lib: add more error context when loading fails #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jul 9, 2024
Previously the code path that read from `CertPaths` that configure a dir from the environment lacked helpful context if the dir couldn't be read. Similarly, the code path that read from a `CertPaths` file would add helpful context if `rustls_pemfile` returned an error, but not if the file open failed. This commit centralizes the job of adding useful context into `CertPaths.load()`. The `rustls_pemfile` specific part in the file path processing can then be removed. This ensures for both dirs and files that if the operation fails there's useful context as to why.
|
Feels uninteresting enough that I'm not going to block on a 2nd review. Will iterate for any post-merge feedback 🌠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code path that reads from
CertPathsthat configure a dir from the environment lacked helpful context if the dir couldn't be read. Similarly, the code path that read from aCertPathsfile would add helpful context ifrustls_pemfilereturned an error, but not if the file open failed.This commit centralizes the job of adding useful context into
CertPaths.load(). Therustls_pemfilespecific part in the file path processing can then be removed. This ensures for both dirs and files that if the operation fails there's useful context as to why.Resolves #116