Fix and defend wasm code using wasi platform #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctz
force-pushed
the
jbp-check-wasm-using-wasi-platform
branch
2 times, most recently
from
aeba11f to
8fb6f48
Compare
ctz
force-pushed
the
jbp-check-wasm-using-wasi-platform
branch
from
8fb6f48 to
d356a59
Compare
djc
approved these changes
Aug 30, 2024
|
I think these changes make a lot of sense given that browser's don't let WASM/JS control what TLS roots are trusted, make raw network connections, etc. Thanks for the proposal :) It might be worth figuring out how to keep CI happy for |
complexspaces
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids all the annoyance with the
wasm32-unknown-unknownplatform, and arguably wasi is more typical for a networked application.This PR is a variation on #122.