Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cargo-semver-checks-action #143

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Sep 18, 2024

We've used cargo-semver-checks with success in many other Rustls repos. It's not perfect but catches a variety of semver breaks that could be missed otherwise.

We've used this with success in many other Rustls repos. It's not
perfect but catches a variety of semver breaks that could be missed
otherwise.
@cpu cpu self-assigned this Sep 18, 2024
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I could have sworn we had the tool here already since I thought about doing this same thing during the RustConf talk on cargo-semver-checks.

@cpu
Copy link
Member Author

cpu commented Sep 18, 2024

Nice! I could have sworn we had the tool here already

same! I only thought to check again after the discussion on the other PR about whether a version bump was needed. It must have fallen through the cracks.

@cpu cpu merged commit 1ba8976 into rustls:main Sep 18, 2024
19 checks passed
@cpu cpu deleted the cpu-ci-semver-check_dev branch September 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants