Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a code sample showing how to use it #65

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Add a code sample showing how to use it #65

merged 3 commits into from
Jan 24, 2024

Conversation

djc
Copy link
Member

@djc djc commented Jan 24, 2024

Was looking for this while writing on rustls/hyper-rustls#253.

@djc djc requested review from cpu and complexspaces January 24, 2024 09:19
cpu
cpu reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree the README could provide more example code, however I have some feedback about the proposed addition.

README.md Outdated Show resolved Hide resolved
complexspaces
complexspaces approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@complexspaces complexspaces merged commit 6cd0232 into main Jan 24, 2024
15 checks passed
@complexspaces complexspaces deleted the code-sample branch March 12, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@complexspaces complexspaces complexspaces approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @complexspaces